1222907 - RemotePlayer UI doesn't reflect the media status while controlled by TV controller

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Screencasting, defect)

Description

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

http://techcrunch.com/2015/03/16/chromecast-now-lets-you-pause-and-play-with-your-tv-remote/

User can play/pause shared video via TV remote controller, if that HDMI-CEC is supported. However, VideoPlayCallback doesn't reflect this status change to MediaCastingBar. [1]

I can reproduce this issue with latest Sony BRAVIA Android TV.

[1] https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/ChromeCast.java#87

Comment 1

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: bug1222907-status-report-to-remote-player-ui.patch

This patch works correctly on real device. Not sure if it matches the coding convention of Fennec.

Comment 2

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

I did some research on Roku support but didn't find any API / document reporting player status from Roku to Fennec. Therefore I only made modification on Chromecast support.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8684843 [details] [diff] [review]
bug1222907-status-report-to-remote-player-ui.patch


>diff --git a/mobile/android/chrome/content/CastingApps.js b/mobile/android/chrome/content/CastingApps.js

>   onRemoteMediaStatus: function(aRemoteMedia) {
>     if (!this.session) {
>       return;
>     }
> 
>     let status = aRemoteMedia.status;
>-    if (status == "completed") {
>-      this.closeExternal();
>+    switch (status) {
>+      case "started":
>+        Messaging.sendRequest({ type: "Casting:Playing" });
>+        break;
>+      case "paused":
>+        Messaging.sendRequest({ type: "Casting:Paused" });
>+        break;
>+      case "completed":
>+        this.closeExternal();
>+        break;

Technically, the RokuApp.jsm code will forward status changes ("started" and "paused") here too. This should not cause a problem because you are just setting visibility of the player controls in MediaCastingBar. Let's land this and get someone to test on Roku for bustage.

Nice patch. Thank you! r+

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

NI to me to help test on Roku

Comment 5

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

I have Roku in Taipei office as well. I can double check the behavior on Roku before check-in.

Comment 6

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Sorry I couldn't find Roku in Taipei office today. It'll be helpful if @mfinkle can help test on Roku.

Comment 7

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=838fa0ae4029

Comment 8

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Ok I got one Roku today. The same issue affects Roku as well (Roku has its own remote controller) and my patch can fix it. Ready to land this patch.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/09bbdb107c10

Comment 11

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/fx-team/rev/58e6110ac261

Comment 12

[Carsten Book [:Tomcat]]

something in this push https://treeherder.mozilla.org/#/jobs?repo=fx-team&revision=e23d0660a042 caused a perma regression in mulet tests like

https://treeherder.mozilla.org/logviewer.html#?job_id=5714391&repo=fx-team

and
https://treeherder.mozilla.org/logviewer.html#?job_id=5714374&repo=fx-team

to bring the tree back into a stable state i backed out all pushes from this checkin to find out if this clears the mulet bustage

Comment 13

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3617e013a579

Comment 14

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=20d1c24bf38e

Comment 15

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

My patch is not the root cause of those perma orange. Mark checkin-needed again.

Comment 16

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/517cb8556db3

Comment 17

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/517cb8556db3