1222980 - Intermittent resource-selection-invoke-insert-source-not-in-document.html | invoking resource selection by inserting <source> in video not in a document - expected FAIL

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Carsten Book [:Tomcat]]

https://treeherder.mozilla.org/logviewer.html#?job_id=16999998&repo=mozilla-inbound

 00:20:19 INFO - TEST-UNEXPECTED-PASS | /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-source-not-in-document.html | invoking resource selection by inserting <source> in video not in a document - expected FAIL

Comment 1

[BMO Automation]

Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.

Comment 2

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: Bug 1222980 - Dispatch |QueueLoadFromSourceTask| to main thread. And end the synchronous section and asynchronously await a stable state when the src is not set. .

Dispatch |QueueLoadFromSourceTask| to main thread to make sure the task will be executed later than loadstart event.

Review commit: https://reviewboard.mozilla.org/r/98126/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/98126/

Comment 3

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: Bug 1222980 - Enable resource-selection-invoke-insert-source-not-in-document.html. .

Review commit: https://reviewboard.mozilla.org/r/98128/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/98128/

Comment 4

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: Bug 1222980 - End the synchronous section and asynchronously await a stable state when the src is not set. .

When the src get errors, we need to end the synchronous section.

Review commit: https://reviewboard.mozilla.org/r/98130/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/98130/

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8817940 [details]
Bug 1222980 - Dispatch |QueueLoadFromSourceTask| to main thread. And end the synchronous section and asynchronously await a stable state when the src is not set. .

https://reviewboard.mozilla.org/r/98126/#review98522

Please merge P1 and P3 so it is easier to understand what this change does. Also move changes to *.ini to another patch.

Comment 6

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: Bug 1222980 - Disable resource-selection-invoke-remove-src.html.

Disable resource-selection-invoke-remove-src.html because it should be failed. Bug 1318196 should be able to fix this test.

Review commit: https://reviewboard.mozilla.org/r/98488/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/98488/

Comment 7

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Comment on attachment 8817940 [details]
Bug 1222980 - Dispatch |QueueLoadFromSourceTask| to main thread. And end the synchronous section and asynchronously await a stable state when the src is not set. .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/98126/diff/1-2/

Comment 8

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Comment on attachment 8817941 [details]
Bug 1222980 - Enable resource-selection-invoke-insert-source-not-in-document.html. .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/98128/diff/1-2/

Comment 9

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8817940 [details]
Bug 1222980 - Dispatch |QueueLoadFromSourceTask| to main thread. And end the synchronous section and asynchronously await a stable state when the src is not set. .

https://reviewboard.mozilla.org/r/98126/#review98772

::: dom/html/HTMLMediaElement.h:972
(Diff revision 2)
> +   * Per spec, Failed with elements: Queue a task, using the DOM manipulation
> +   * task source, to fire a simple event named error at the candidate element.
> +   * So dispatch |QueueLoadFromSourceTask| to main thread to make sure the task
> +   * will be executed later than loadstart event.
> +   */
> +  void DealingFailWithElements(nsIContent* aSourceElement);

DealWithFailedElement

::: dom/html/HTMLMediaElement.cpp:2195
(Diff revision 2)
>      if (NS_SUCCEEDED(LoadResource())) {
>        return;
>      }
>  
>      // If we fail to load, loop back and try loading the next resource.
>      DispatchAsyncSourceError(child);

Do we need to call DealingFailWithElements() instead here?

Comment 10

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8817941 [details]
Bug 1222980 - Enable resource-selection-invoke-insert-source-not-in-document.html. .

https://reviewboard.mozilla.org/r/98128/#review98774

Comment 11

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8818438 [details]
Bug 1222980 - Disable resource-selection-invoke-remove-src.html.

https://reviewboard.mozilla.org/r/98488/#review98776

Comment 12

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Comment on attachment 8817940 [details]
Bug 1222980 - Dispatch |QueueLoadFromSourceTask| to main thread. And end the synchronous section and asynchronously await a stable state when the src is not set. .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/98126/diff/2-3/

Comment 13

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Comment on attachment 8817941 [details]
Bug 1222980 - Enable resource-selection-invoke-insert-source-not-in-document.html. .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/98128/diff/2-3/

Comment 14

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Comment on attachment 8818438 [details]
Bug 1222980 - Disable resource-selection-invoke-remove-src.html.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/98488/diff/1-2/

Comment 15

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Please land Bug 1222980 and Bug 1118337 together. Thanks.

Comment 16

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Comment on attachment 8817940 [details]
Bug 1222980 - Dispatch |QueueLoadFromSourceTask| to main thread. And end the synchronous section and asynchronously await a stable state when the src is not set. .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/98126/diff/3-4/

Comment 17

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Comment on attachment 8817941 [details]
Bug 1222980 - Enable resource-selection-invoke-insert-source-not-in-document.html. .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/98128/diff/3-4/

Comment 18

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Comment on attachment 8818438 [details]
Bug 1222980 - Disable resource-selection-invoke-remove-src.html.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/98488/diff/2-3/

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e30080454885
Dispatch |QueueLoadFromSourceTask| to main thread. And end the synchronous section and asynchronously await a stable state when the src is not set. r=jwwang.
https://hg.mozilla.org/integration/autoland/rev/1b8b8519481c
Enable resource-selection-invoke-insert-source-not-in-document.html. r=jwwang.
https://hg.mozilla.org/integration/autoland/rev/d5eeb39cb354
Disable resource-selection-invoke-remove-src.html. r=jwwang

Comment 20

[Carsten Book [:Tomcat]]

backedout for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=7946811&repo=autoland

Comment 21

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07f561589c13
Backed out changeset d5eeb39cb354 
https://hg.mozilla.org/integration/autoland/rev/3b2c07699f11
Backed out changeset 1b8b8519481c 
https://hg.mozilla.org/integration/autoland/rev/b52a2c95eacd
Backed out changeset e30080454885

Comment 22

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Comment on attachment 8817940 [details]
Bug 1222980 - Dispatch |QueueLoadFromSourceTask| to main thread. And end the synchronous section and asynchronously await a stable state when the src is not set. .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/98126/diff/4-5/

Comment 23

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Comment on attachment 8817941 [details]
Bug 1222980 - Enable resource-selection-invoke-insert-source-not-in-document.html. .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/98128/diff/4-5/

Comment 24

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Comment on attachment 8818438 [details]
Bug 1222980 - Disable resource-selection-invoke-remove-src.html.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/98488/diff/3-4/

Comment 25

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Fixed. See try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d1a70d43f9350fe19d2cd58a452437acc9dd5e90

Please land Bug 1222980 and Bug 1118337 together. Thanks.

(In reply to Carsten Book [:Tomcat] from comment #20)
> backedout for test failures like
> https://treeherder.mozilla.org/logviewer.html#?job_id=7946811&repo=autoland

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54c0b421fbd0
Dispatch |QueueLoadFromSourceTask| to main thread. And end the synchronous section and asynchronously await a stable state when the src is not set. r=jwwang.
https://hg.mozilla.org/integration/autoland/rev/3dc503829365
Enable resource-selection-invoke-insert-source-not-in-document.html. r=jwwang.
https://hg.mozilla.org/integration/autoland/rev/b00f52ee67ba
Disable resource-selection-invoke-remove-src.html. r=jwwang

Comment 27

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/54c0b421fbd0
https://hg.mozilla.org/mozilla-central/rev/3dc503829365
https://hg.mozilla.org/mozilla-central/rev/b00f52ee67ba

Comment 28

[Ryan VanderMeulen [:RyanVM]]

Is this worth uplifting to Aurora?

Comment 29

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

My suggestion is to ride the train since this is for fixing test only.

(In reply to [PTO 20-Dec to 28-Dec] Ryan VanderMeulen [:RyanVM] from comment #28)
> Is this worth uplifting to Aurora?