Closed Bug 1222980 Opened 5 years ago Closed 4 years ago

Intermittent resource-selection-invoke-insert-source-not-in-document.html | invoking resource selection by inserting <source> in video not in a document - expected FAIL

Categories

(Core :: DOM: Core & HTML, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox51 --- wontfix
firefox52 --- wontfix
firefox53 --- fixed

People

(Reporter: cbook, Assigned: ctai)

References

()

Details

(Keywords: intermittent-failure)

Attachments

(3 files, 1 obsolete file)

https://treeherder.mozilla.org/logviewer.html#?job_id=16999998&repo=mozilla-inbound

 00:20:19 INFO - TEST-UNEXPECTED-PASS | /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-source-not-in-document.html | invoking resource selection by inserting <source> in video not in a document - expected FAIL
Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.
Priority: -- → P3
Comment on attachment 8817940 [details]
Bug 1222980 - Dispatch |QueueLoadFromSourceTask| to main thread. And end the synchronous section and asynchronously await a stable state when the src is not set. .

https://reviewboard.mozilla.org/r/98126/#review98522

Please merge P1 and P3 so it is easier to understand what this change does. Also move changes to *.ini to another patch.
Attachment #8817940 - Flags: review?(jwwang) → review-
Attachment #8817942 - Attachment is obsolete: true
Attachment #8817942 - Flags: review?(jwwang)
Comment on attachment 8817940 [details]
Bug 1222980 - Dispatch |QueueLoadFromSourceTask| to main thread. And end the synchronous section and asynchronously await a stable state when the src is not set. .

https://reviewboard.mozilla.org/r/98126/#review98772

::: dom/html/HTMLMediaElement.h:972
(Diff revision 2)
> +   * Per spec, Failed with elements: Queue a task, using the DOM manipulation
> +   * task source, to fire a simple event named error at the candidate element.
> +   * So dispatch |QueueLoadFromSourceTask| to main thread to make sure the task
> +   * will be executed later than loadstart event.
> +   */
> +  void DealingFailWithElements(nsIContent* aSourceElement);

DealWithFailedElement

::: dom/html/HTMLMediaElement.cpp:2195
(Diff revision 2)
>      if (NS_SUCCEEDED(LoadResource())) {
>        return;
>      }
>  
>      // If we fail to load, loop back and try loading the next resource.
>      DispatchAsyncSourceError(child);

Do we need to call DealingFailWithElements() instead here?
Attachment #8817940 - Flags: review?(jwwang) → review+
Comment on attachment 8817941 [details]
Bug 1222980 - Enable resource-selection-invoke-insert-source-not-in-document.html. .

https://reviewboard.mozilla.org/r/98128/#review98774
Attachment #8817941 - Flags: review?(jwwang) → review+
Comment on attachment 8818438 [details]
Bug 1222980 - Disable resource-selection-invoke-remove-src.html.

https://reviewboard.mozilla.org/r/98488/#review98776
Attachment #8818438 - Flags: review?(jwwang) → review+
Please land Bug 1222980 and Bug 1118337 together. Thanks.
Keywords: checkin-needed
Assignee: nobody → ctai
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e30080454885
Dispatch |QueueLoadFromSourceTask| to main thread. And end the synchronous section and asynchronously await a stable state when the src is not set. r=jwwang.
https://hg.mozilla.org/integration/autoland/rev/1b8b8519481c
Enable resource-selection-invoke-insert-source-not-in-document.html. r=jwwang.
https://hg.mozilla.org/integration/autoland/rev/d5eeb39cb354
Disable resource-selection-invoke-remove-src.html. r=jwwang
Keywords: checkin-needed
backedout for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=7946811&repo=autoland
Flags: needinfo?(ctai)
Fixed. See try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d1a70d43f9350fe19d2cd58a452437acc9dd5e90

Please land Bug 1222980 and Bug 1118337 together. Thanks.

(In reply to Carsten Book [:Tomcat] from comment #20)
> backedout for test failures like
> https://treeherder.mozilla.org/logviewer.html#?job_id=7946811&repo=autoland
Flags: needinfo?(ctai)
Keywords: checkin-needed
Pushed by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/54c0b421fbd0
Dispatch |QueueLoadFromSourceTask| to main thread. And end the synchronous section and asynchronously await a stable state when the src is not set. r=jwwang.
https://hg.mozilla.org/integration/autoland/rev/3dc503829365
Enable resource-selection-invoke-insert-source-not-in-document.html. r=jwwang.
https://hg.mozilla.org/integration/autoland/rev/b00f52ee67ba
Disable resource-selection-invoke-remove-src.html. r=jwwang
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/54c0b421fbd0
https://hg.mozilla.org/mozilla-central/rev/3dc503829365
https://hg.mozilla.org/mozilla-central/rev/b00f52ee67ba
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Is this worth uplifting to Aurora?
Flags: needinfo?(ctai)
My suggestion is to ride the train since this is for fixing test only.

(In reply to [PTO 20-Dec to 28-Dec] Ryan VanderMeulen [:RyanVM] from comment #28)
> Is this worth uplifting to Aurora?
Flags: needinfo?(ctai)
You need to log in before you can comment on or make changes to this bug.