In Gecko right now, Promise.resolve.call(undefined, foo) has the same behavior as Promise.resolve.call(Promise, foo), and some Gaia tests rely on that. However per spec the former should throw while the latter should work. As a result, fixing bug 1170760 breaks Gaia unit tests.
Created attachment 8684914 [details] [review] [gaia] bzbarsky:fix-promise-abuses > mozilla-b2g:master
2 years ago
Attachment #8684914 - Flags: review?(timdream)
Attachment #8684914 - Flags: review?(timdream) → review+
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S11 (13Nov)
[Blocking Requested - why for this release]: v2.5 would probably need this patch to fix the test failure, too.
blocking-b2g: --- → 2.5?
@Tim, Would this Promise misusage issue affect Gaia v2.5 ? If yes, it may need to be uplifted to v2.5. Could you take a look at it? thank you.
Bug 1170760 only reaches Gecko 45, so it should not affect v2.5, I think.
Assignee: nobody → bzbarsky
would need approval for 2.5
As it doesn't affect 2.5. We do not need a 2.5 uplift. Thanks
Agree with Mahe
You need to log in before you can comment on or make changes to this bug.