1223004 - Some Gaia unit tests misuse Promise static methods

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Boris Zbarsky [:bzbarsky]]

In Gecko right now, Promise.resolve.call(undefined, foo) has the same behavior as Promise.resolve.call(Promise, foo), and some Gaia tests rely on that.  However per spec the former should throw while the latter should work.  As a result, fixing bug 1170760 breaks Gaia unit tests.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] bzbarsky:fix-promise-abuses > mozilla-b2g:master

Comment 2

[Gregor Wagner [:gwagner]]

Thanks bz!

Comment 3

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/ac4003f6969a1fe705caf1ecbfb7275faee39cd7

Comment 4

[yifan [:yifan][:yliao]]

[Blocking Requested - why for this release]:

v2.5 would probably need this patch to fix the test failure, too.

Comment 5

[Fischer [:Fischer]]

@Tim,
Would this Promise misusage issue affect Gaia v2.5 ?
If yes, it may need to be uplifted to v2.5.
Could you take a look at it?
thank you.

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Bug 1170760 only reaches Gecko 45, so it should not affect v2.5, I think.

Comment 7

[Carsten Book [:Tomcat]]

would need approval for 2.5

Comment 8

[Mahendra Potharaju [:mahe]]

As it doesn't affect 2.5. We do not need a 2.5 uplift. 

Thanks

Comment 9

[Josh Cheng [:josh]]

Agree with Mahe