1223018 - Rename about:telemetry "System Information" section to "Session Information"

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P4)

Description

[Georg Fritzsche [:gfritzsche]]

In about:telemetry, the "System Information" section doesn't really contain information about the system.
Most of the information in there is about the current session, so we should rename it to "Session Information".

Comment 1

[Georg Fritzsche [:gfritzsche]]

The changes can be viewed by navigating to about:telemetry.

This requires updating the following places with "system" vs. "session":
* the html for the about page:
  https://dxr.mozilla.org/mozilla-central/rev/e2a910c048dc82fc3be53475f18e7f81f03e377b/toolkit/content/aboutTelemetry.xhtml#117,119,122
* the JavaScript file:
  https://dxr.mozilla.org/mozilla-central/rev/e2a910c048dc82fc3be53475f18e7f81f03e377b/toolkit/content/aboutTelemetry.js#1625-1628
* the file that contains the strings:
  https://dxr.mozilla.org/mozilla-central/source/toolkit/locales/en-US/chrome/global/aboutTelemetry.dtd#107

Comment 2

[Penh Lenh]

Hi Georg,

I'd like to start working on this bug.

Penh

Comment 3

[Alessio Placitelli [:Dexter]]

Hi Penh, I'm assigning this bug to you. To get started, follow the guidelines in comment 1. Feel free to get back to us if you need anything else!

Comment 4

[Penh Lenh]

Attachment: Rename System Information To Session Information

Comment 5

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8687250 [details] [diff] [review]
Rename System Information To Session Information

Review of attachment 8687250 [details] [diff] [review]:
-----------------------------------------------------------------

That is the right place to change the heading, thanks.
I think we should change the internal names too (the ones mentioned in comment 1, like e.g. aboutTelemetry.systemInfoSection to aboutTelemetry.sessionInfoSection).

Comment 6

[Penh Lenh]

Attachment: change the internal names

Comment 7

[Alessio Placitelli [:Dexter]]

Comment on attachment 8687683 [details] [diff] [review]
change the internal names

Penh, thank you for your submissions!

Next time you submit a patch for review, be sure to set a reviewer: this is needed so your patch gets the needed attention.

To request a review, when attaching a new patch, find the "review" entry and change the flag to "?". Then start writing the name of the reviewer, a dropdown will get shown with a list of suggestions.

I've flagged :gfritzsche for you on this patch!

Comment 8

[Georg Fritzsche [:gfritzsche]]

I was already talking with Penh Lenh about this elsewhere, so this should be fine :)

Comment 9

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8687683 [details] [diff] [review]
change the internal names

Review of attachment 8687683 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, this looks good.

Lets get the changes into one single patch with a good commit message, e.g. like this bugs title (Rename about:telemetry "System Information" section to "Session Information").
Flag me for review on that and then we can get this change landed.

Comment 10

[Penh Lenh]

Attachment: bug-1223018-fix.patch

Please review this patch.

Comment 11

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8688448 [details] [diff] [review]
bug-1223018-fix.patch

This patch is empty, lets figure out what went wrong here.

Comment 12

[Penh Lenh]

Attachment: bug-1223018-fix.patch

Please review this new one! I think it's right direction. xD

Comment 13

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8688463 [details] [diff] [review]
bug-1223018-fix.patch

Review of attachment 8688463 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, this looks good!

Comment 14

[Georg Fritzsche [:gfritzsche]]

Lets get this landed...
We can skip pushing to the try server here (running automated tests across lots of different platforms) because there is no automated test coverage of about:telemetry at the moment.

Comment 15

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/8751a85b4f25

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8751a85b4f25