Closed Bug 1223028 Opened 4 years ago Closed 4 years ago

Exhaust all server-originated emulator commands and await expected response

Categories

(Testing :: Marionette, defect, P2)

defect

Tracking

(firefox45 fixed)

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: ato, Assigned: ato)

References

Details

(Keywords: pi-marionette-client)

Attachments

(1 file)

The Python client does not currently exhaust all the command requests originating from the server as pointed out by :bhsu in https://bugzilla.mozilla.org/show_bug.cgi?id=1211503#c12.

This prevents making multiple calls to runEmulatorCmd and runEmulatorShell inside executeScript/executeJSScript/executeAsyncScript.  This failure makes marionette-webapi fail.

We should loop through all the commands originating from the server until we get sent back a response.
Assignee: nobody → ato
Status: NEW → ASSIGNED
Priority: -- → P2
Bug 1223028: Exhaust server-originated commands

The Python client does not currently exhaust all the command
requests originating from the server as pointed out by :bhsu in
https://bugzilla.mozilla.org/show_bug.cgi?id=1211503#c12.

This prevents making multiple calls to runEmulatorCmd and runEmulatorShell
inside executeScript/executeJSScript/executeAsyncScript.  This failure
makes marionette-webapi fail.

We loop through all the commands originating from the server until we
get sent back a response.

r=dburns
Comment on attachment 8684936 [details]
MozReview Request: Bug 1223028: Exhaust server-originated commands

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24679/diff/1-2/
Attachment #8684936 - Flags: review?(dburns)
Comment on attachment 8684936 [details]
MozReview Request: Bug 1223028: Exhaust server-originated commands

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24679/diff/1-2/
Comment on attachment 8684936 [details]
MozReview Request: Bug 1223028: Exhaust server-originated commands

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24679/diff/2-3/
Attachment #8684936 - Flags: review?(dburns) → review+
Comment on attachment 8684936 [details]
MozReview Request: Bug 1223028: Exhaust server-originated commands

https://reviewboard.mozilla.org/r/24679/#review22363
Backed out because of breakage.
Blocks: 1081529
https://hg.mozilla.org/mozilla-central/rev/fc40ce54b4e0
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.