Closed
Bug 1223028
Opened 9 years ago
Closed 9 years ago
Exhaust all server-originated emulator commands and await expected response
Categories
(Testing :: Marionette Client and Harness, defect, P2)
Testing
Marionette Client and Harness
Tracking
(firefox45 fixed)
RESOLVED
FIXED
mozilla45
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
References
Details
(Keywords: pi-marionette-client)
Attachments
(1 file)
The Python client does not currently exhaust all the command requests originating from the server as pointed out by :bhsu in https://bugzilla.mozilla.org/show_bug.cgi?id=1211503#c12. This prevents making multiple calls to runEmulatorCmd and runEmulatorShell inside executeScript/executeJSScript/executeAsyncScript. This failure makes marionette-webapi fail. We should loop through all the commands originating from the server until we get sent back a response.
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Comment 1•9 years ago
|
||
Bug 1223028: Exhaust server-originated commands The Python client does not currently exhaust all the command requests originating from the server as pointed out by :bhsu in https://bugzilla.mozilla.org/show_bug.cgi?id=1211503#c12. This prevents making multiple calls to runEmulatorCmd and runEmulatorShell inside executeScript/executeJSScript/executeAsyncScript. This failure makes marionette-webapi fail. We loop through all the commands originating from the server until we get sent back a response. r=dburns
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8684936 [details] MozReview Request: Bug 1223028: Exhaust server-originated commands Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24679/diff/1-2/
Attachment #8684936 -
Flags: review?(dburns)
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8684936 [details] MozReview Request: Bug 1223028: Exhaust server-originated commands Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24679/diff/1-2/
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8684936 [details] MozReview Request: Bug 1223028: Exhaust server-originated commands Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24679/diff/2-3/
Updated•9 years ago
|
Attachment #8684936 -
Flags: review?(dburns) → review+
Comment 5•9 years ago
|
||
Comment on attachment 8684936 [details] MozReview Request: Bug 1223028: Exhaust server-originated commands https://reviewboard.mozilla.org/r/24679/#review22363
Assignee | ||
Comment 7•9 years ago
|
||
Backed out because of breakage.
Comment 10•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/fc40ce54b4e0
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Updated•1 year ago
|
Product: Testing → Remote Protocol
Comment 11•1 year ago
|
||
Moving bugs for Marionette client due to component changes.
Component: Marionette → Marionette Client and Harness
Product: Remote Protocol → Testing
You need to log in
before you can comment on or make changes to this bug.
Description
•