Closed
Bug 1223100
Opened 10 years ago
Closed 10 years ago
Add settings option to start the app with the email composer option with device logs attached
Categories
(Firefox for iOS :: Build & Test, defect)
Tracking
()
RESOLVED
FIXED
1.3
| Tracking | Status | |
|---|---|---|
| fxios | 1.3+ | --- |
People
(Reporter: sleroux, Assigned: sleroux)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
86 bytes,
patch
|
bnicholson
:
review+
st3fan
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Comment 1•10 years ago
|
||
To which address?
| Assignee | ||
Comment 2•10 years ago
|
||
Which one would you like? Do we have an email we can capture these logs with?
| Assignee | ||
Updated•10 years ago
|
tracking-fxios:
--- → ?
Updated•10 years ago
|
Updated•10 years ago
|
| Assignee | ||
Updated•10 years ago
|
Assignee: nobody → sleroux
Status: NEW → ASSIGNED
| Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8687984 -
Flags: review?(sarentz)
Attachment #8687984 -
Flags: review?(bnicholson)
Comment 4•10 years ago
|
||
Comment on attachment 8687984 [details] [diff] [review]
https://github.com/mozilla/firefox-ios/commit/d22031acf70c4c63ecc57822b8809d4f2ab069ce
Lots of new code in this, but I think the risk should be pretty low since it will (hopefully) only be triggered when this debug option is enabled.
I wonder if we can add tests for all of these new debug features?
Attachment #8687984 -
Flags: review?(bnicholson) → review+
| Assignee | ||
Comment 5•10 years ago
|
||
The best I can think of for testing the debug feature is to have a basic unit test that create an app delegate, sets the flag to true, and sees if profile/BVC get loaded or not. The other ones are also difficult to test since they are all tied to app startup.
Comment 6•10 years ago
|
||
Comment on attachment 8687984 [details] [diff] [review]
https://github.com/mozilla/firefox-ios/commit/d22031acf70c4c63ecc57822b8809d4f2ab069ce
LGTM
Attachment #8687984 -
Flags: review?(sarentz) → review+
| Assignee | ||
Comment 7•10 years ago
|
||
Landed
12bf9a1488c966c48dee98c0d6c967f3e3bd5557
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3
You need to log in
before you can comment on or make changes to this bug.
Description
•