1223128 - [PulseGuardian] dbinit.py --dummy is broken

Status: RESOLVED FIXED

(Webtools :: Pulse, defect, P2)

Description

[Mark Côté [:mcote]]

It seems that running dbinit.py with the --dummy option is broken:

$ python pulseguardian/dbinit.py --dummy
INFO:__main__:Finished initializing database.
Traceback (most recent call last):
  File "pulseguardian/dbinit.py", line 87, in <module>
    dummy_data()
  File "pulseguardian/dbinit.py", line 56, in dummy_data
    password='dummy', management_api=pulse_management)
TypeError: new_user() got an unexpected keyword argument 'username'

This is almost certainly from the model changes I did a little while ago.

This function isn't used very often, but it should still be fixed.

Comment 1

[Mike Yao]

(In reply to Mark Côté [:mcote] from comment #0)
> It seems that running dbinit.py with the --dummy option is broken:
> 
> $ python pulseguardian/dbinit.py --dummy
> INFO:__main__:Finished initializing database.
> Traceback (most recent call last):
>   File "pulseguardian/dbinit.py", line 87, in <module>
>     dummy_data()
>   File "pulseguardian/dbinit.py", line 56, in dummy_data
>     password='dummy', management_api=pulse_management)
> TypeError: new_user() got an unexpected keyword argument 'username'
> 
> This is almost certainly from the model changes I did a little while ago.
> 
> This function isn't used very often, but it should still be fixed.

Hi Mark,

Please send the ticket to me.

Thanks

Comment 2

[Mike Yao]

Attachment: dbinit-1223128-1.patch

db dummy doesn't work because model changed.

Comment 3

[Mark Côté [:mcote]]

Hi, I get an error with this patch:

DETAIL:  Key (owner_id)=(1) is not present in table "pulse_users".

This is because there is no PulseUser object.  Before the models changed, there was a single User object that also acted as a PulseUser.  We split PulseUser out because that way a single User (which represents a human user by a unique email address) could own multiple PulseUsers (which represent accounts in RabbitMQ).

The simplest fix here is to create a single User object and then four PulseUser objects, and use the PulseUser object IDs when you create the Queues.

Comment 4

[Mike Yao]

Attachment: dbinit-1223128-2.patch

Improved first patch but the "init_and_clear_db" need to change for deleting both of user and pulse_user. So just upload another patch and finish all then do the pull request on github.

Comment 5

[Mike Yao]

Checked "init_and_clear_db" function, it seems re-created new database, no data remain. So don't need to think about how delete users. The patch was done, pull request created.

(In reply to Mike Yao from comment #4)
> Created attachment 8687684 [details] [diff] [review]
> dbinit-1223128-2.patch
> 
> Improved first patch but the "init_and_clear_db" need to change for deleting
> both of user and pulse_user. So just upload another patch and finish all
> then do the pull request on github.

Comment 6

[Mark Côté [:mcote]]

Great!  There were just a couple tiny issues, which I fixed myself before merging your commit it.  Also, in the future, our commit messages are normally "Bug <bug id>: <summary> r=<reviewer>".  I rewrote yours before merging, so you can see an example.

Thanks for the patch!  We'll find you something else now. :)