1223135 - "<file>" permission for type "Open Popup Windows" from older version does no longer work

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Matthias]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:42.0) Gecko/20100101 SeaMonkey/2.39
Build ID: 20151103191810

Steps to reproduce:

Open a local file with popups.


Actual results:

Popups are blocked in Seamonkey 2.39. It worked fine allowing popups for <file> in data manager up to 2.38.


Expected results:

Popup Windows should open.

Comment 1

[Rainer Bielefeld]

Please attach a sample document (files system as .zip)

Comment 2

[Matthias]

Attachment: local-popups.zip

Start this sample document to open several popups from a local file.

Comment 3

[Matthias]

Attachment: IN-Start.htm

Zip does not work. Second try as html.

Comment 4

[Rainer Bielefeld]

NOT reproducible with  SeaMonkey German 2.39b1 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:42.0 from official download area)  Gecko/20100101  Firefox/42.0  Build 20151028234211  (Classic Theme) on German WIN7 64bit:

0. Launch browser → Download smaple file attachment "2015-11-09 23:47 CET, Matthias "
1. Menu 'File → Open file → browse for sample file and open it
   » Yellow warning above contents: "SeaMonkey prevented popups from opening"
   » In contents area a list with 3 URLs and a button with "Open Windows" appears"
2. Doing nothing will open "google.de"
3.Repeating Step 1 and clicking [Open Windows]:
  » addditionally to "google.de" "lokalisten.de", "facebook.com", "merkur.de"
    will be opened

Additional Information:
a) Behavior similar to FF 45.0a1 (2015-11-08), but in FF the "Options2 button in
   warning line as an item "Allow Pop ups form file .... "
b) My IE11 opens "lokalisten.de", "facebook.com", "merkur.de" without any warning
c) I currently can't see a possibility to allow popups from that local file

Comment 5

[Rainer Bielefeld]

Steps how to reproduce:
10. Launch SM 2.38 Browser
11.  Menu 'tools → Popup Manager → Manage Popups'
12.  Click asterisk in Domains pane → [Add] → Type "<file> for host name  → Select 
   "Open Popup Windows" for type' → [Add] → Uncheck "Use default" → radio button
   "Allow"
13. Menu 'File → Open file → browse for sample file and open it
   » "google.de" "lokalisten.de", "facebook.com", "merkur.de" will open 
     immediately without any warning
14. Quit SM 2.38
15. Launch SM 2.39 browser
16. Menu 'File → Open file → browse for sample file and open it
    Expeted: "google.de" "lokalisten.de", "facebook.com", "merkur.de" will open 
             immediately without any warning
    Actual: As step 1.

Additional Information:
d) Checking permissions manager will show that permission for "<file> still does 
   exist, but it will not work
e) deleting that permission in 2.39 and creating the same one again in SM 2.39
   will create permission what works in 2.39 AND in 2.38
f) so question is whether
f1) we have a bug in 2.39?
f2) we have had a bug until 2.38 what accepted a faulty <file> permission?
    I can't tell

Comment 6

[Rainer Bielefeld]

g) With  German SeaMonkey 2.38  (X11; Linux x86_64; rv:41.0)  Gecko/20100101 
   Firefox/41.0 Build 20150923193515  (Classic Theme) on VirtualBox Ubuntu 14
   nither "<file>" nor "file" works for 
h) like (g) with 
   German SeaMonkey 2.41a1  (X11; Linux x86_64; rv:44.0)  Gecko/20100101 
   Firefox/44.0 Build 20151029003002  (Classic Theme) on VirtualBox Ubuntu 14
i) Additional information: 
   <http://forums.mozillazine.org/viewtopic.php?f=38&t=698855>
k) Possibly related: <https://bugzilla.mozilla.org/buglist.cgi?cmdtype=dorem&remaction=run&namedcmd=DUPs1223135&sharer_id=41036>
l) NEW + regression for now although I still haven't a clue 
   where exactly the bug might be

Comment 7

[Matthias]

I don't use the German Version of Seamonkey. I have this Problem with the English (US) Version. 
I'll try reproduce this problem with the German Version of Seamonkey.

Comment 8

[Rainer Bielefeld]

(In reply to Matthias from comment #7)
I don't think that this problem is Language related, currently there is no need for further investigation.

Comment 9

[Matthias]

(In reply to Rainer Bielefeld from comment #8)
> (In reply to Matthias from comment #7)
> I don't think that this problem is Language related, currently there is no
> need for further investigation.

It is not a language problem, but it is a problem of SM 2.39. I tried to reproduce the problem with SM 2.39 and it was reproducible. 

1. Uninstall SM 2.39 English (US) and delete all profile-files and folders.

2. Install SM 2.39 German.

3. Click asterisk in Domains pane → [Add] → Type "<file>" for host name  → Select 
   "Open Popup Windows" for "type" → [Add] → Uncheck "Use default" → radio button "Allow"

4. Menu File → Open file → browse for sample file and open it
   Expected: "google.de" "lokalisten.de", "facebook.com", "merkur.de" will open 
             immediately without any warning
   Actual:   » Yellow warning above contents: "SeaMonkey prevented popups from opening"
             » In contents area a list with 3 URLs and a button with "Open Windows" appears"
             Doing nothing will open just "google.de"

5. Uninstall SM 2.39 and install SM 2.38 German

6. Click asterisk in Domains pane → [Add] → Type "<file>" for host name  → Select 
   "Open Popup Windows" for "type" → [Add] → Uncheck "Use default" → radio button "Allow"

7. Menu File → Open file → browse for sample file and open it
   "google.de" "lokalisten.de", "facebook.com", "merkur.de" will open immediately without any warning

8. Uninstall SM 2.38 and install SM 2.39 again

9. Upload the sample file to a webserver and open the URL

10. All 3 URLs will open immediately. 


I'm quite sure, there is a bug in SM 2.39, which is not language related when opening popups from local files, not from files on webservers. The setting for local popups is ignored in SM 2.39 even with a clean installation.

Comment 10

[Philip Chee]

I think the permissions manager is now using origin. Perhaps this has some effect.

Comment 11

[[e-mail]]

Attachment: Switch Page Info to use principals

By switching Page Info to use principals I can open Page Info up for the file and grant it the permission to open popups. I'm not sure how to deal with this in the rest of the UI though.

Comment 12

[Philip Chee]

Comment on attachment 8690432 [details] [diff] [review]
Switch Page Info to use principals

(In reply to [e-mail] from comment #11)
> Created attachment 8690432 [details] [diff] [review]
> Switch Page Info to use principals
> 
> By switching Page Info to use principals I can open Page Info up for the
> file and grant it the permission to open popups. I'm not sure how to deal
> with this in the rest of the UI though.

1. As far as this goes this works, so r+
2. In Firefox the options menu-button in the notification far has an extra option at the top: Allow pop-ups for file:///IN-Start.html
3. In SeaMonkey going to "Manage Popups" goes to a non functional about:data
Perhaps we should revive the old stand-alone permissions manager until the data manager is fixed.

Comment 13

[[e-mail]]

(In reply to Philip Chee from comment #12)
> 2. In Firefox the options menu-button in the notification far has an extra
> option at the top: Allow pop-ups for file:///IN-Start.html

Aha, good point, the SeaMonkey code checks for a host here.

> 3. In SeaMonkey going to "Manage Popups" goes to a non functional about:data
> Perhaps we should revive the old stand-alone permissions manager until the
> data manager is fixed.

Wasn't the data manager bustage due to the changes in permissions? Or is there some new bustage?

Comment 14

[[e-mail]]

Attachment: Followup patch

This allows you to allow popups on file: pages (although the test page changes its location so you need to be quick).

Comment 15

[Philip Chee]

Comment on attachment 8691329 [details] [diff] [review]
Followup patch

OK. This works.

After allowing popups from a local file. When I open the data manager and choose "permissions" The domain for this permission is blank. Which is not surprising but we should really show something here like "file:"

Comment 16

[[e-mail]]

Pushed comm-central changeset 69eb7df3847f.

Comment 17

[Matthias]

The problem is not fixed yet. Adding the path of a local file to exceptions in Firefox 50.1.0 is working without any problems. 

Doing the same in Seamonkey 2.46 results in showing "null" in permission manager instead of the path and the filename.

Comment 18

[Philip Chee]

> Doing the same in Seamonkey 2.46 results in showing "null" in permission
> manager instead of the path and the filename.
Can you try on 2.47?

Comment 19

[Matthias]

I tried with 2.47a1 and it also shows "null" in permission manager after adding the path and filename.

Comment 20

[Frank-Rainer Grahl (:frg)]

I changed the validation code and thought I also checked it. Must have made an error somewhere. Will open a followup bug. Tools -> Popup Manager -> Allow Popups from This Website should work fine in 2.47+ as a workaround

Comment 21

[Frank-Rainer Grahl (:frg)]

Just a reminder to open a followup bug.