1223215 - Remove ToSize() and ThebesSize()

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Nicholas Nethercote [inactive]]

More trimming of gfx2DGlue.h.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Convert some gfx{Point,Size} to gfx::{Point,Size}

This lets us remove some Thebes{Point,Size}() and To{Point,Size}() calls.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Remove a ToSize() call

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: (part 3) - Moz2Dify DeviceToUser(gfxSize) and UserToDevice(gfxSize)

Comment 4

[Nicholas Nethercote [inactive]]

Attachment: (part 5) - Remove ToSize() and ThebesSize()

I'm not totally sure about this one, because there are still plenty of gfxSize
uses left in the codebase and it might be necessary to have these converters
for more Moz2Dification in the future...

Comment 5

[Nicholas Nethercote [inactive]]

Attachment: (part 4) - Remove a ToSize() call

Comment 6

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0a9eaf9b1060c4286558c67e144d0edf4bfc0598
Bug 1223215 (part 1) - Convert some gfx{Point,Size} to gfx::{Point,Size}. r=roc.

https://hg.mozilla.org/integration/mozilla-inbound/rev/19ae7923085613ed408b65a24f69eb3697ee4e99
Bug 1223215 (part 2) - Remove a ToSize() call. r=jwatt.

https://hg.mozilla.org/integration/mozilla-inbound/rev/ffdfe16e5481ec7186484517ce393581544c4d06
Bug 1223215 (part 3) - Moz2Dify DeviceToUser(gfxSize) and UserToDevice(gfxSize). r=jrmuizel.

https://hg.mozilla.org/integration/mozilla-inbound/rev/55c0c90e4ac4cf4ddcd173155bbf4a0d027a0c8e
Bug 1223215 (part 4) - Remove a ToSize() call. r=jrmuizel.

https://hg.mozilla.org/integration/mozilla-inbound/rev/ea759b57d58a59bad86873d56a5bb0878d8844e9
Bug 1223215 (part 5) - Remove ToSize() and ThebesSize(). r=jrmuizel.

Comment 7

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/55cea35b3cc657886368c1b22f11cf70def6ba0c
Backout ea759b57d58a (bug 1223215 part 5) because the removed functions are still useful. r=me.

Comment 8

[Nicholas Nethercote [inactive]]

> Backout ea759b57d58a (bug 1223215 part 5) because the removed functions are
> still useful. r=me.

I reverted part 5 because I ended up needing ToSize() and ThebesSize() in some subsequent Moz2Dification work.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0a9eaf9b1060
https://hg.mozilla.org/mozilla-central/rev/19ae79230856
https://hg.mozilla.org/mozilla-central/rev/ffdfe16e5481
https://hg.mozilla.org/mozilla-central/rev/55c0c90e4ac4
https://hg.mozilla.org/mozilla-central/rev/ea759b57d58a

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Merge of the backout:
https://hg.mozilla.org/mozilla-central/rev/55cea35b3cc6