Closed
Bug 1223261
Opened 9 years ago
Closed 9 years ago
[Testcase] Audio should be playback correctly when open the pref "dom.audiochannel.mutedByDefault"
Categories
(Firefox OS Graveyard :: AudioChannel, defect)
Tracking
(firefox45 fixed, firefox46 fixed)
RESOLVED
FIXED
2.6 S2 - 12/4
People
(Reporter: alwu, Assigned: alwu)
References
(Depends on 1 open bug)
Details
Attachments
(1 file)
In b2g, the channel is muted by default, and then unmuted by the system app.
We need to simulate this case to make sure the basic audio playback can work successfully.
Assignee | ||
Comment 1•9 years ago
|
||
Bug 1223261 - Add the audio playback test for the case muted-by-default.
Attachment #8685246 -
Flags: review?(amarchesini)
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8685246 [details]
MozReview Request: Bug 1223261 - Add the audio playback test for the case muted-by-default. r=baku.
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24769/diff/1-2/
Updated•9 years ago
|
Attachment #8685246 -
Flags: review?(amarchesini) → review+
Comment 3•9 years ago
|
||
Comment on attachment 8685246 [details]
MozReview Request: Bug 1223261 - Add the audio playback test for the case muted-by-default. r=baku.
https://reviewboard.mozilla.org/r/24769/#review22299
Assignee | ||
Comment 4•9 years ago
|
||
Try-server result.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=15ca020f6e0e
Assignee | ||
Comment 5•9 years ago
|
||
Trying to fix the test case fail, new try-server result.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=436295364bf9
Assignee | ||
Comment 6•9 years ago
|
||
Still has test case fail, new try-server result.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bbd68aa63b49
Assignee | ||
Updated•9 years ago
|
Attachment #8685246 -
Flags: review+ → review?(amarchesini)
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8685246 [details]
MozReview Request: Bug 1223261 - Add the audio playback test for the case muted-by-default. r=baku.
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24769/diff/2-3/
Updated•9 years ago
|
Attachment #8685246 -
Flags: review?(amarchesini) → review+
Comment 8•9 years ago
|
||
Comment on attachment 8685246 [details]
MozReview Request: Bug 1223261 - Add the audio playback test for the case muted-by-default. r=baku.
https://reviewboard.mozilla.org/r/24769/#review22539
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
Comment 10•9 years ago
|
||
sorry backed out for test failurs like https://treeherder.mozilla.org/logviewer.html#?job_id=3354320&repo=b2g-inbound
Flags: needinfo?(alwu)
Comment 11•9 years ago
|
||
Assignee | ||
Comment 12•9 years ago
|
||
Hi, Carsten,
I think this test faliure is resulted by other changeset, not my patch.
This patch doesn't include any Gecko changing.
It just changes the content of "test_browserElement_inproc(oop)_AudioChannel", so it shouldn't break any other test.
Flags: needinfo?(alwu) → needinfo?(cbook)
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 13•9 years ago
|
||
Hi, Wes,
Could you help me check-in this patch?
Thanks!
Flags: needinfo?(wkocher)
Assignee | ||
Comment 14•9 years ago
|
||
Maybe find the reason for timeout, update patch later.
Assignee | ||
Updated•9 years ago
|
Summary: [B2G] Add the test to simulate the "muted by default" audio playback → [Testcase] Audio should be playback correctly when open the pref "dom.audiochannel.mutedByDefault"
Assignee | ||
Comment 15•9 years ago
|
||
Assignee | ||
Comment 16•9 years ago
|
||
Comment on attachment 8685246 [details]
MozReview Request: Bug 1223261 - Add the audio playback test for the case muted-by-default. r=baku.
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24769/diff/3-4/
Attachment #8685246 -
Attachment description: MozReview Request: Bug 1223261 - Add the audio playback test for the case muted-by-default. → MozReview Request: Bug 1223261 - Add the audio playback test for the case muted-by-default. r=baku.
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 17•9 years ago
|
||
Keywords: checkin-needed
Comment 18•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.6 S2 - 12/4
Backed out in:
https://hg.mozilla.org/mozilla-central/rev/cc9c6cd756cb
for an unacceptable level of intermittent orange. See dependent bugs above or in commit message.
Status: RESOLVED → REOPENED
Flags: needinfo?(alwu)
Resolution: FIXED → ---
Assignee | ||
Comment 20•9 years ago
|
||
Flags: needinfo?(alwu)
Assignee | ||
Comment 21•9 years ago
|
||
Comment on attachment 8685246 [details]
MozReview Request: Bug 1223261 - Add the audio playback test for the case muted-by-default. r=baku.
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24769/diff/4-5/
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 22•9 years ago
|
||
Hi Alastor,
applying 0514fe364d43
patching file dom/browser-element/mochitest/browserElement_AudioChannel.js
Hunk #3 FAILED at 167
1 out of 3 hunks FAILED -- saving rejects to file dom/browser-element/mochitest/browserElement_AudioChannel.js.rej
patch failed to apply
abort: fix up the merge and run hg transplant --continue
could you take a look, thanks!
Flags: needinfo?(alwu)
Keywords: checkin-needed
Assignee | ||
Comment 23•9 years ago
|
||
Comment on attachment 8685246 [details]
MozReview Request: Bug 1223261 - Add the audio playback test for the case muted-by-default. r=baku.
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24769/diff/5-6/
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(alwu) → needinfo?(cbook)
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 24•9 years ago
|
||
Keywords: checkin-needed
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(cbook)
Comment 25•9 years ago
|
||
bugherder |
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•