Closed Bug 1223261 Opened 4 years ago Closed 4 years ago

[Testcase] Audio should be playback correctly when open the pref "dom.audiochannel.mutedByDefault"

Categories

(Firefox OS Graveyard :: AudioChannel, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(firefox45 fixed, firefox46 fixed)

RESOLVED FIXED
2.6 S2 - 12/4
Tracking Status
firefox45 --- fixed
firefox46 --- fixed

People

(Reporter: alwu, Assigned: alwu)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

In b2g, the channel is muted by default, and then unmuted by the system app.
We need to simulate this case to make sure the basic audio playback can work successfully.
Bug 1223261 - Add the audio playback test for the case muted-by-default.
Attachment #8685246 - Flags: review?(amarchesini)
Comment on attachment 8685246 [details]
MozReview Request: Bug 1223261 - Add the audio playback test for the case muted-by-default. r=baku.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24769/diff/1-2/
Blocks: 1223298
Attachment #8685246 - Flags: review?(amarchesini) → review+
Comment on attachment 8685246 [details]
MozReview Request: Bug 1223261 - Add the audio playback test for the case muted-by-default. r=baku.

https://reviewboard.mozilla.org/r/24769/#review22299
Trying to fix the test case fail, new try-server result.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=436295364bf9
Still has test case fail, new try-server result.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bbd68aa63b49
Attachment #8685246 - Flags: review+ → review?(amarchesini)
Comment on attachment 8685246 [details]
MozReview Request: Bug 1223261 - Add the audio playback test for the case muted-by-default. r=baku.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24769/diff/2-3/
Attachment #8685246 - Flags: review?(amarchesini) → review+
Comment on attachment 8685246 [details]
MozReview Request: Bug 1223261 - Add the audio playback test for the case muted-by-default. r=baku.

https://reviewboard.mozilla.org/r/24769/#review22539
Keywords: checkin-needed
sorry backed out for test failurs like https://treeherder.mozilla.org/logviewer.html#?job_id=3354320&repo=b2g-inbound
Flags: needinfo?(alwu)
Hi, Carsten,
I think this test faliure is resulted by other changeset, not my patch.
This patch doesn't include any Gecko changing.
It just changes the content of "test_browserElement_inproc(oop)_AudioChannel", so it shouldn't break any other test.
Flags: needinfo?(alwu) → needinfo?(cbook)
Keywords: checkin-needed
Hi, Wes,
Could you help me check-in this patch?
Thanks!
Flags: needinfo?(wkocher)
Maybe find the reason for timeout, update patch later.
Flags: needinfo?(wkocher)
Flags: needinfo?(cbook)
Keywords: checkin-needed
Summary: [B2G] Add the test to simulate the "muted by default" audio playback → [Testcase] Audio should be playback correctly when open the pref "dom.audiochannel.mutedByDefault"
Comment on attachment 8685246 [details]
MozReview Request: Bug 1223261 - Add the audio playback test for the case muted-by-default. r=baku.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24769/diff/3-4/
Attachment #8685246 - Attachment description: MozReview Request: Bug 1223261 - Add the audio playback test for the case muted-by-default. → MozReview Request: Bug 1223261 - Add the audio playback test for the case muted-by-default. r=baku.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9ebcec50fefa
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.6 S2 - 12/4
Depends on: 1230015
Depends on: 1230020
Backed out in:
https://hg.mozilla.org/mozilla-central/rev/cc9c6cd756cb
for an unacceptable level of intermittent orange.  See dependent bugs above or in commit message.
Status: RESOLVED → REOPENED
Flags: needinfo?(alwu)
Resolution: FIXED → ---
Comment on attachment 8685246 [details]
MozReview Request: Bug 1223261 - Add the audio playback test for the case muted-by-default. r=baku.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24769/diff/4-5/
Keywords: checkin-needed
Hi Alastor,

applying 0514fe364d43
patching file dom/browser-element/mochitest/browserElement_AudioChannel.js
Hunk #3 FAILED at 167
1 out of 3 hunks FAILED -- saving rejects to file dom/browser-element/mochitest/browserElement_AudioChannel.js.rej
patch failed to apply
abort: fix up the merge and run hg transplant --continue

could you take a look, thanks!
Flags: needinfo?(alwu)
Keywords: checkin-needed
Comment on attachment 8685246 [details]
MozReview Request: Bug 1223261 - Add the audio playback test for the case muted-by-default. r=baku.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24769/diff/5-6/
Flags: needinfo?(alwu) → needinfo?(cbook)
Keywords: checkin-needed
Keywords: checkin-needed
Keywords: checkin-needed
Flags: needinfo?(cbook)
https://hg.mozilla.org/mozilla-central/rev/68ff75086870
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.