Fix -Wunreachable-code warning in tools/profiler

RESOLVED FIXED in Firefox 45

Status

()

Core
Gecko Profiler
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

unspecified
mozilla45
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox45 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8685241 [details] [diff] [review]
Wunreachable-code_tools-profiler.patch

The `continue` is not reached after the abort() in debug builds:

tools/profiler/core/platform-linux.cc:363:11: warning: code will never be executed [-Wunreachable-code]
Attachment #8685241 - Flags: review?(bgirard)

Updated

3 years ago
Attachment #8685241 - Flags: review?(bgirard) → review+

Comment 2

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1c21badcbd34
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
(Assignee)

Updated

3 years ago
Depends on: 1235502
(Assignee)

Updated

3 years ago
Blocks: 1235717
You need to log in before you can comment on or make changes to this bug.