1223327 - [Music]Can't play files whose extension has been modified from .aac to .mp4 format.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Autumn.Qiu(Leave from Mozilla)]

Attachment: logcat_mp4.txt

[1.Description]:
[Aries KK v2.5&v2.6][Music]Copy files whose extension has been modified from .aac to .mp4 format to device, open Music app and try to play them, there is no voice, progress bar does not move and time displays as 0:00.
See Attachment:Aries_KK_v2.6_mp4.3gp & logcat_mp4.txt. & sample_mp4.zip.
Found Time:17:45

[2.Testing Steps]: 
Premise: There are some files files whose extension has been modified from .aac to .mp4 format in device.

1.Open Music.
2.Select the file and try to play them.

[3.Expected Result]: 
On step 2, the file plays normally.

[4.Actual Result]: 
On step 2, there is no voice, progress bar does not move and time displays as 0:00.

[5.Reproduction build]: 
Device: Aries KK v2.6(Master)(Affected) 
Build ID               20151109151826
Gaia Revision          23cab7ea0fcecab7689d340baf604e024e88f9a3
Gaia Date              2015-11-09 06:13:17
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/e1ef2be156de1dad31bb4189a51b178b12b23340
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151109.143842
Firmware Date          Mon Nov  9 14:38:50 UTC 2015
Bootloader             s1

Device: Aries KK v2.5 (Affected) 
Build ID               20151109233837
Gaia Revision          07baf613699fa6225359c7f04825c5caeb71d424
Gaia Date              2015-11-09 21:32:50
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/772f6c235fc48d91efd6346f5b3d8b216eb2dcb1
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151109.225902
Firmware Date          Mon Nov  9 22:59:11 UTC 2015
Bootloader             s1

Device: Flame KK v2.6 512MB(Master)(Unaffected) 
Build ID               20151109150204
Gaia Revision          23cab7ea0fcecab7689d340baf604e024e88f9a3
Gaia Date              2015-11-09 06:13:17
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/e1ef2be156de1dad31bb4189a51b178b12b23340
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151109.182508
Firmware Date          Mon Nov  9 18:25:22 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame KK v2.5 512MB (Unaffected) 
Build ID               20151109004552
Gaia Revision          cf646c52bb947af28329b0a100df91d1b1f2a907
Gaia Date              2015-11-09 02:55:50
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/4eafef5b80f8985c94c4a067f130d37513e1a581
Gecko Version          44.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151109.041411
Firmware Date          Mon Nov  9 04:14:26 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame KK v2.2 512MB (Unaffected) 
Build ID               20151109032503
Gaia Revision          885647d92208fb67574ced44004ab2f29d23cb45
Gaia Date              2015-10-07 13:05:24
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/e6ea91190b53
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151109.065527
Firmware Date          Mon Nov  9 06:55:39 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,10/10

[7.TCID]: 
Free Test

[8.NOTE]
Update Aries device to Android system,  The same files can be played normally.

Comment 1

[Autumn.Qiu(Leave from Mozilla)]

Attachment: Aries_KK_v2.6_mp4.3gp

Comment 2

[Autumn.Qiu(Leave from Mozilla)]

Attachment: sample_mp4.zip

Comment 3

[No-Jun Park [:njpark]]

I am not sure whether it is a valid move to change the extension to mp4.  Can mp4 act as a container to AAC? Actually, I wonder whether this is a music bug at all, and not audiochannel bug.  ni?ing djf again for assessment.

Sort of reminds me of this bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=956238

Comment 4

[Hubert Figuiere [:hub]]

(In reply to No-Jun Park [:njpark] from comment #3)
> I am not sure whether it is a valid move to change the extension to mp4. 
> Can mp4 act as a container to AAC? 

Yes it can. But the official extension is .m4a as does iTunes.

Comment 5

[David Flanagan [:djf]]

Music files have to have a valid music extension or the music app will just ignore them. But once found, I don't think we care about the extension.  Before we go any further, I'd like to verify that hte .aac file plays if its extension is not modified.  If it can play when it is called foo.aac, but does not play when renamed to foo.mp4, then that is probably a bug, and you should ask Jim to investigate.

Comment 6

[No-Jun Park [:njpark]]

Hmm, I see that when I change the attached music file's extension back to aac, the music app still cannot locate the music files.  I suppose this aac file is of unsupported type?

Comment 7

[No-Jun Park [:njpark]]

Hmm, on Aries, I can still repro this, and as the original reporter says, not on flame.  When I change the extension to aac, the music app cannot find the file, probably because it's not looking for the .aac suffix.

Comment 8

[No-Jun Park [:njpark]]

being unable to play legitimate music file on aries is an issue.  nominating for 2.6

Comment 9

[No-Jun Park [:njpark]]

Additional Info from djf:

 djf|afk → djf
4:05 PM <djf> njpark, squib: ADTS is for streaming audio, not for audio files, so perhaps we don't support that part.

4:06 PM <djf> "In addition to the MP4, 3GP and other ISO base media file format-based container formats for file storage, AAC audio data was first packaged in file based form for the MPEG-2 standard by using a more basic format called Audio Data Interchange Format (ADIF),[38] consisting of a single header followed by the raw AAC audio data blocks.[39] However, if the data is to be streamed within an MPEG-2 transport stream, a self-synchronizing format called an Audio 
4:06 PM <djf> Data Transport Stream (ADTS) is used, consisting of a series of frames, each frame having a header followed by the AAC audio data.[38] This file and streaming-based format are defined in MPEG-2 Part 7, but are only considered informative by MPEG-4, so an MPEG-4 decoder does not need to support either format.[38] "
4:07 PM <djf> That's from https://en.wikipedia.org/wiki/Advanced_Audio_Coding#Container_formats
4:09 PM <njpark> ah, then it's strange that it's playing on flame device
4:09 PM <djf> njpark: also, it does not seem to play natively in Firefox Developer Edition on my mac
4:10 PM <djf> maybe that comes down to the blobs on the device then or something
4:10 PM <djf> Firefox tries to play it as a movie instead of audio, but maybe that is just because of the .mp4 extension.
4:15 PM <djf> njpark: also, the files in sample_mp4.zip are not mp4 files.
4:16 PM <djf> njpark: they don't begin with the proper magic number.  So even if we can play them on flame, we probably don't parse their metadata correctly. (Though squib would be the expert on that)

Comment 10

[David Flanagan [:djf]]

I took a look at the files and noticed that these are not actually MP4 files. I'm not sure what the container format is, but it is something sort of odd. So it does not surprise me that we can't play them.  And the fact that they're encoded for streaming makes me think that these are not ordinary music files and that we don't need to support them.

Comment 11

[Hubert Figuiere [:hub]]

The attached MP4 file show as:

AAC_8khz_Mono_5.mp4: Audio file with ID3 version 2.3.0, contains: MPEG ADTS, AAC, v2 LC, 8 kHz, monaural

ADTS is used by MPEG TS to stream audio mainly in AAC. This is what you are encountering.


Example m4a from the iTunes store:

01 Shepherd of Fire.m4a: ISO Media, Apple iTunes ALAC/AAC-LC (.M4A) Audio

Totally different. The latter is totally supported.