1223446 - Thumbnail blurs do not match thumbnails

Status: RESOLVED DUPLICATE of bug 1229460

(Firefox for iOS :: Home screen, defect)

Description

[Brian Nicholson (:bnicholson)]

Attachment: Screenshot 2015-11-10 09.22.42.png

Go to several sites, then check top sites thumbnails. Eventually, thumbnails no longer match their blurs. See screenshot: search.yahoo.com, people.mozilla.org, and The Mozilla Project are all the wrong colors.

Comment 1

[Brian Nicholson (:bnicholson)]

I found that this is consistently reproducible if:
* The current tab is home (showing Top Sites)
* I close/reopen the browser, restoring to Top Sites.

Comment 2

[Stephan Leroux [:sleroux]]

I bet this is being caused by the blurring happening on another thread and coming back to do a different cell. I'll investigate.

Comment 3

[Stephan Leroux [:sleroux]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1239

I've reverted moving the blurring operation on the background and kept it on the main thread. This will regress the perf by a tiny bit but it will work. I think what you were mentioning about UIKit behaving badly in the background is manifesting itself in this bug. Looking at the code, the cell that's getting passed through should get captured by the async/sync dispatch blocks [1] so that should be fine. The only thing I can think of is the writing into CGContext in the applyLightEffect logic [2] is behaving badly in the background.

[1] https://github.com/mozilla/firefox-ios/blob/master/Client/Frontend/Home/TopSitesPanel.swift#L456

[2] https://github.com/mozilla/firefox-ios/blob/master/ThirdParty/Apple/UIImage+ImageEffects.m#L264

Comment 4

[Aaron Train [:aaronmt]]

1.2?

Comment 5

[Stephan Leroux [:sleroux]]

Yup - Landing this now

Comment 6

[Stephan Leroux [:sleroux]]

Landed

88d37a4fd1eb2275d55f80a0671a1babc784d173

Comment 7

[Stephan Leroux [:sleroux]]

Landed

88d37a4fd1eb2275d55f80a0671a1babc784d173

Comment 8

[Stephan Leroux [:sleroux]]

I'm still seeing this issue in the latest TF build (1302). Reopening.

Comment 9

[Aaron Train [:aaronmt]]

Alongside the blur I am also seeing completely wrong respective Favicons for tiles; I filed bug https://bugzilla.mozilla.org/show_bug.cgi?id=1229460

Comment 10

[Stephan Leroux [:sleroux]]

Closing as a dupe of 1229460 since that's the actual issue