Minor ArchiveReader test fixes

RESOLVED FIXED in Firefox 45

Status

()

Core
DOM
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

Trunk
mozilla45
Points:
---

Firefox Tracking Flags

(firefox45 fixed)

Details

Attachments

(3 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

2 years ago
Created attachment 8685562 [details] [diff] [review]
part 1 - Always finishTest() in test_nonUnicode.html.

This could cause hangs if the last part does not throw an exception.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=002fe94dc8fe
Attachment #8685562 - Flags: review?(amarchesini)
(Assignee)

Comment 2

2 years ago
Created attachment 8685563 [details] [diff] [review]
part 2 - Make ArchiveReader tests use pushPrefEnv.
Attachment #8685563 - Flags: review?(amarchesini)
(Assignee)

Comment 3

2 years ago
Created attachment 8685564 [details] [diff] [review]
part 3 - Change where generator is created.

Mostly this lets us take advantage of things created during the initial setup.

(This is mostly useful for converting these tests to use the special powers file creator, so I can pass in the list of created files to the generator.)
Attachment #8685564 - Flags: review?(amarchesini)
Attachment #8685562 - Flags: review?(amarchesini) → review+
Attachment #8685563 - Flags: review?(amarchesini) → review+
Attachment #8685564 - Flags: review?(amarchesini) → review+

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/52d43b0a27eb
https://hg.mozilla.org/mozilla-central/rev/d75b1a6bc6bc
https://hg.mozilla.org/mozilla-central/rev/178b6d4c6e30
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox45: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.