Closed Bug 1223660 Opened 9 years ago Closed 7 years ago

Add option to disable "Go to copied URL" in Settings

Categories

(Firefox for iOS :: General, defect)

Product:
Firefox for iOS
Component:
General
Platform:
All
iOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Iteration:
1.28
Tracking Flags:
Tracking Status
fxios 9.0 ---

People

(Reporter: tecgirl, Assigned: jhugman)

References

Details

(Whiteboard: [MobileCore][ClipboardBar][needstrings][Strings])

Attachments

(5 files, 1 obsolete file)

Settings-GoToURL-Toggle.png
107.11 KB, image/png
Details
Screen Shot 2016-01-27 at 2.25.16 PM.png
290.63 KB, image/png
tecgirl
: ui-review+
Details
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3022
55 bytes, text/x-github-pull-request
farhan
: review+
Details | Review
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3023
55 bytes, text/x-github-pull-request
farhan
: review+
Details | Review
IMG_61C5186A9796-1.jpeg
74.25 KB, image/jpeg
Details 
      No description provided.
Depends on: 1186013
Blocks: 1186013
No longer depends on: 1186013
Assignee: nobody → bmunar
review this!
Attachment #8712891 - Flags: ui-review?(randersen)
Status: NEW → ASSIGNED
Rank: 2
tracking-fxios: --- → +
Hardware: Other → All
Whiteboard: [needstrings]
Attachment #8712891 - Flags: ui-review?(randersen) → ui-review+
Attachment #8712890 - Flags: review?(sleroux)
Attachment #8712890 - Flags: ui-review?(randersen) → ui-review+
Comment on attachment 8712890 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/1481

Code looks good - just one nit.

Initially I was a bit confused as to what this setting meant though. 'Go to Copied URL When opening Firefox' implies that we will navigate to the URL whenever its on the pasteboard instead of showing the option to go to the url instead. Would it make more sense to name this option:

'Show Open Copied Link Banner'
'When opening Firefox'

or something along those lines?
Attachment #8712890 - Flags: review?(sleroux) → review+
"Offer to open links on clipboard"

or

"Offer to open copied links"
"Offer to open copied links" +1
string change?? ^
Flags: needinfo?(randersen)
(In reply to Stephan Leroux [:sleroux] from comment #6)
> "Offer to open copied links"
+2
Flags: needinfo?(randersen)
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Whiteboard: [needstrings] → [MobileCore][ClipboardBar][needstrings]
Assignee: bmunar → nobody
Assignee: nobody → jhugman
Iteration: --- → 1.28
Strings in separate PR for expeditious landing.
Attachment #8896040 - Flags: review?(fpatel)
Attachment #8712890 - Attachment description: PR - see screenshot → Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3023
Attachment #8712890 - Attachment is obsolete: true
Attachment #8712890 - Attachment description: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3023 → Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/1481
Status: REOPENED → ASSIGNED
This should probably be tested with the XCUITests, but re-launching the app in the simulator is clears the profile each time (despite changing the LaunchArguments).

It also needs accessibilityIdentifiers to Settings.
Attachment #8896038 - Flags: review?(fpatel) → review+
Attachment #8896040 - Flags: review?(fpatel) → review+
Merged into master.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED
Whiteboard: [MobileCore][ClipboardBar][needstrings] → [MobileCore][ClipboardBar][needstrings][Strings]
Attached image IMG_61C5186A9796-1.jpeg — 
Screenshot of this setting
Verified as fixed in latest master and v9.0(5607)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: