1223662 - [B2G] IMEI Cannot be retrieved when airplane mode is ON.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Bevis Tseng[:bevis][:btseng](Exited)]

This is a regression of bug 1159591.
We shall compare the |mmiServiceCode| with MMI_KS_SC_IMEI instead of RIL.MMI_KS_SC_IMEI:

https://hg.mozilla.org/mozilla-central/rev/ac1cfdfcdd29#l1.12

Comment 1

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: (v1) Part 1: Check mmiServiceCode with correct constant.

Comment 2

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: (v2) Improve Test Coverage.

Comment 3

[Bevis Tseng[:bevis][:btseng](Exited)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8fc801212fe6

Comment 4

[Edgar Chen [:edgar] (OOO ~ 04/02)]

Comment on attachment 8685810 [details] [diff] [review]
(v1) Part 1: Check mmiServiceCode with correct constant.

Review of attachment 8685810 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for catching this.

Comment 5

[Edgar Chen [:edgar] (OOO ~ 04/02)]

Comment on attachment 8685812 [details] [diff] [review]
(v2) Improve Test Coverage.

Review of attachment 8685812 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you.

Comment 6

[Edgar Chen [:edgar] (OOO ~ 04/02)]

[Blocking Requested - why for this release]: This is a regression of bug 1159591.

Comment 7

[Bevis Tseng[:bevis][:btseng](Exited)]

Treehelder result:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8fc801212fe6&exclusion_profile=false

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/7ef208a52042
https://hg.mozilla.org/integration/b2g-inbound/rev/169482e6ed9b

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7ef208a52042
https://hg.mozilla.org/mozilla-central/rev/169482e6ed9b