Closed Bug 1223668 Opened 10 years ago Closed 10 years ago

[TV 2.5] Store remote control client page Gecko preference in Gaia

Categories

(Firefox OS Graveyard :: Gaia::TV::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::TV::System
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.5+, b2g-v2.5 fixed, b2g-master fixed)

Status:
RESOLVED FIXED
Milestone:
FxOS-S11 (13Nov)
Project Flags:
blocking-b2g 2.5+
Tracking Flags:
Tracking Status
b2g-v2.5 --- fixed
b2g-master --- fixed

People

(Reporter: etsai, Unassigned)

References

Details

(Whiteboard: [ft:conndevices][partner-blocker][partner-cherry-pick])

Attachments

(3 files, 2 obsolete files)

Store remote control client page preference in Gaia
46 bytes, text/x-github-pull-request
rexboy
: review+
Details | Review
[gaia] ferjm:bug1223668.followup > mozilla-b2g:master
46 bytes, text/x-github-pull-request
julienw
: review+
jocheng
: approval-gaia-v2.5+
Details | Review
PR for 2.5
46 bytes, text/x-github-pull-request
jocheng
: approval-gaia-v2.5+
Details | Review
in bug 1197749, schien's comment on attachment 8682988 [details] [diff] [review], move remote control client page Gecko preference in Gaia. Since it's related with remote-control-client app
Comment on attachment 8685823 [details] [review] Store remote control client page preference in Gaia Looks ok to me
Attachment #8685823 - Flags: review?(rexboy) → review+
with comment changes needed.
Attachment #8685820 - Attachment is obsolete: true
https://github.com/mozilla-b2g/gaia/commit/3fb68dc7084a1339eb18a87a1a593a51448e56a8
Status: NEW → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S11 (13Nov)
Comment on attachment 8687137 [details] [review] [gaia] ferjm:bug1223668.followup > mozilla-b2g:master r=me if the try is green ;)
Attachment #8687137 - Flags: review+
Comment on attachment 8687137 [details] [review] [gaia] ferjm:bug1223668.followup > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #):1223668 [User impact] if declined: TV remote control feature malfunction [Testing completed]: local test passed [Risk to taking this patch] (and alternatives if risky): less, only custom gecko preferences [String changes made]: N/A
Attachment #8687137 - Flags: approval-gaia-v2.5?
Attachment #8687137 - Flags: approval-gaia-v2.5? → approval-gaia-v2.5?(jocheng)
blocking-b2g: --- → 2.5+
status-b2g-v2.5: --- → affected
status-b2g-master: --- → fixed
Whiteboard: [ft:conndevices][partner-blocker][partner-cherry-pick]
Comment on attachment 8687137 [details] [review] [gaia] ferjm:bug1223668.followup > mozilla-b2g:master Approve as required for TV remote control feature.
Attachment #8687137 - Flags: approval-gaia-v2.5?(jocheng) → approval-gaia-v2.5+
hi, i tried to uplift this to 2.5 but it fails with : updating local tracking ref 'refs/remotes/origin/v2.5' Tomcats-MacBook-Pro-2:gaia Tomcat$ git cherry-pick 75e7653d9deed8abf76ebfd069f0dfefdbfb9a0b error: could not apply 75e7653... Bug 1223668 - Follow up: Make linter happy. r=me hint: after resolving the conflicts, mark the corrected paths hint: with 'git add <paths>' or 'git rm <paths>' hint: and commit the result with 'git commit' could you take a look and provide a 2.5 PR request. Thanks!
Flags: needinfo?(etsai)
Attached file PR for 2.5 —
[Approval Request Comment] [Bug caused by] (feature/regressing bug #): 1223668 [User impact] if declined: Remote Control mal-function [Testing completed]: local test [Risk to taking this patch] (and alternatives if risky): low, only default preference [String changes made]:N/A
Flags: needinfo?(etsai)
Attachment #8691862 - Flags: approval-gaia-v2.5?
Comment on attachment 8691862 [details] [review] PR for 2.5 Required for TV 2.5 remote control.
Attachment #8691862 - Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
Attachment #8691861 - Attachment is obsolete: true
Comment on attachment 8687137 [details] [review] [gaia] ferjm:bug1223668.followup > mozilla-b2g:master Hi Carsten, Could you please help to uplift this patch as well? It's different from Eric's one in comment 14 and aims to fix the linter errors introduced by that one. Thanks.
Flags: needinfo?(cbook)
(In reply to Luke Chang [:lchang] from comment #17) > Comment on attachment 8687137 [details] [review] > [gaia] ferjm:bug1223668.followup > mozilla-b2g:master > > Hi Carsten, > > Could you please help to uplift this patch as well? > > It's different from Eric's one in comment 14 and aims to fix the linter > errors introduced by that one. > > Thanks. Hi Luke, no problem, pushed in https://github.com/mozilla-b2g/gaia/commit/50c5babe34fb2b055da34fdde6847aabffe73246
Flags: needinfo?(cbook)
Carsten, Thanks a lot.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: