Closed
Bug 1223668
Opened 9 years ago
Closed 9 years ago
[TV 2.5] Store remote control client page Gecko preference in Gaia
Categories
(Firefox OS Graveyard :: Gaia::TV::System, defect)
Tracking
(blocking-b2g:2.5+, b2g-v2.5 fixed, b2g-master fixed)
People
(Reporter: etsai, Unassigned)
References
Details
(Whiteboard: [ft:conndevices][partner-blocker][partner-cherry-pick])
Attachments
(3 files, 2 obsolete files)
46 bytes,
text/x-github-pull-request
|
rexboy
:
review+
|
Details | Review |
46 bytes,
text/x-github-pull-request
|
julienw
:
review+
jocheng
:
approval-gaia-v2.5+
|
Details | Review |
46 bytes,
text/x-github-pull-request
|
jocheng
:
approval-gaia-v2.5+
|
Details | Review |
in bug 1197749, schien's comment on attachment 8682988 [details] [diff] [review], move remote control client page Gecko preference in Gaia. Since it's related with remote-control-client app
Comment 1•9 years ago
|
||
Reporter | ||
Comment 2•9 years ago
|
||
Attachment #8685823 -
Flags: review?(rexboy)
Comment 3•9 years ago
|
||
Comment on attachment 8685823 [details] [review] Store remote control client page preference in Gaia Looks ok to me
Attachment #8685823 -
Flags: review?(rexboy) → review+
Comment 4•9 years ago
|
||
with comment changes needed.
Reporter | ||
Updated•9 years ago
|
Keywords: checkin-needed
Reporter | ||
Updated•9 years ago
|
Attachment #8685820 -
Attachment is obsolete: true
Comment 5•9 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/3fb68dc7084a1339eb18a87a1a593a51448e56a8
Status: NEW → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S11 (13Nov)
Comment 6•9 years ago
|
||
Comment 7•9 years ago
|
||
This commit breaks the linter https://treeherder.mozilla.org/logviewer.html#?job_id=2958432&repo=gaia
Comment 8•9 years ago
|
||
Comment on attachment 8687137 [details] [review] [gaia] ferjm:bug1223668.followup > mozilla-b2g:master r=me if the try is green ;)
Attachment #8687137 -
Flags: review+
Comment 9•9 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/fa426f2d2672b92a7939aed060e882bff5f9bac0
Reporter | ||
Comment 10•9 years ago
|
||
Comment on attachment 8687137 [details] [review] [gaia] ferjm:bug1223668.followup > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #):1223668 [User impact] if declined: TV remote control feature malfunction [Testing completed]: local test passed [Risk to taking this patch] (and alternatives if risky): less, only custom gecko preferences [String changes made]: N/A
Attachment #8687137 -
Flags: approval-gaia-v2.5?
Reporter | ||
Updated•9 years ago
|
Attachment #8687137 -
Flags: approval-gaia-v2.5? → approval-gaia-v2.5?(jocheng)
Updated•9 years ago
|
blocking-b2g: --- → 2.5+
status-b2g-v2.5:
--- → affected
status-b2g-master:
--- → fixed
Whiteboard: [ft:conndevices][partner-blocker][partner-cherry-pick]
Comment 11•9 years ago
|
||
Comment on attachment 8687137 [details] [review] [gaia] ferjm:bug1223668.followup > mozilla-b2g:master Approve as required for TV remote control feature.
Attachment #8687137 -
Flags: approval-gaia-v2.5?(jocheng) → approval-gaia-v2.5+
Comment 12•9 years ago
|
||
hi, i tried to uplift this to 2.5 but it fails with : updating local tracking ref 'refs/remotes/origin/v2.5' Tomcats-MacBook-Pro-2:gaia Tomcat$ git cherry-pick 75e7653d9deed8abf76ebfd069f0dfefdbfb9a0b error: could not apply 75e7653... Bug 1223668 - Follow up: Make linter happy. r=me hint: after resolving the conflicts, mark the corrected paths hint: with 'git add <paths>' or 'git rm <paths>' hint: and commit the result with 'git commit' could you take a look and provide a 2.5 PR request. Thanks!
Flags: needinfo?(etsai)
Comment 13•9 years ago
|
||
Reporter | ||
Comment 14•9 years ago
|
||
[Approval Request Comment] [Bug caused by] (feature/regressing bug #): 1223668 [User impact] if declined: Remote Control mal-function [Testing completed]: local test [Risk to taking this patch] (and alternatives if risky): low, only default preference [String changes made]:N/A
Flags: needinfo?(etsai)
Attachment #8691862 -
Flags: approval-gaia-v2.5?
Comment 15•9 years ago
|
||
laned on 2.5 https://github.com/mozilla-b2g/gaia/commit/5b660b5c68eb55b4ab8ee950acc251eaf90c33bf thanks Eric!
Comment 16•9 years ago
|
||
Comment on attachment 8691862 [details] [review] PR for 2.5 Required for TV 2.5 remote control.
Attachment #8691862 -
Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
Updated•9 years ago
|
Attachment #8691861 -
Attachment is obsolete: true
Comment 17•9 years ago
|
||
Comment on attachment 8687137 [details] [review] [gaia] ferjm:bug1223668.followup > mozilla-b2g:master Hi Carsten, Could you please help to uplift this patch as well? It's different from Eric's one in comment 14 and aims to fix the linter errors introduced by that one. Thanks.
Flags: needinfo?(cbook)
Comment 18•9 years ago
|
||
(In reply to Luke Chang [:lchang] from comment #17) > Comment on attachment 8687137 [details] [review] > [gaia] ferjm:bug1223668.followup > mozilla-b2g:master > > Hi Carsten, > > Could you please help to uplift this patch as well? > > It's different from Eric's one in comment 14 and aims to fix the linter > errors introduced by that one. > > Thanks. Hi Luke, no problem, pushed in https://github.com/mozilla-b2g/gaia/commit/50c5babe34fb2b055da34fdde6847aabffe73246
Flags: needinfo?(cbook)
Comment 19•9 years ago
|
||
Carsten, Thanks a lot.
You need to log in
before you can comment on or make changes to this bug.
Description
•