Closed Bug 1223701 Opened 9 years ago Closed 9 years ago

Stop using icon sprites for command buttons

Categories

(DevTools :: Shared Components, defect)

defect
Not set
normal

Tracking

(firefox45 fixed)

RESOLVED FIXED
Firefox 45
Tracking Status
firefox45 --- fixed

People

(Reporter: ntim, Assigned: ntim)

References

(Blocks 1 open bug)

Details

(Keywords: addon-compat)

Attachments

(2 files, 3 obsolete files)

We can use an SVG filter and CSS opacity to style the icons.
Blocks: 1173397
No longer blocks: 1173397
Depends on: 1173397
Blocks: 1174395
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Attachment #8686259 - Flags: review?(bgrinstead)
Attachment #8686260 - Flags: review?(bgrinstead)
Fixed issue reported via IRC.
Attachment #8686260 - Attachment is obsolete: true
Attachment #8686260 - Flags: review?(bgrinstead)
Attachment #8686267 - Flags: review?(bgrinstead)
Attachment #8686265 - Attachment is obsolete: true
removed an useless rule.
Attachment #8686267 - Attachment is obsolete: true
Attachment #8686267 - Flags: review?(bgrinstead)
Attachment #8686270 - Flags: review?(bgrinstead)
This could affect icon display for devtools extensions that register a command button (the buttons on the right, like responsive design mode and split console toggle).  The most likely way this would be done is if they registered a new gcli command and also specify a `buttonId` field, then set the image in CSS.  I don't know how common this really is, just making sure it's tagged.
Keywords: addon-compat
Comment on attachment 8686270 [details] [diff] [review]
Part 2 - Use CSS to style command button icons (v3.1)

Review of attachment 8686270 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me, thanks!
Attachment #8686270 - Flags: review?(bgrinstead) → review+
Attachment #8686259 - Flags: review?(bgrinstead) → review+
https://hg.mozilla.org/mozilla-central/rev/dfb8a480a4de
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Product: Firefox → DevTools
Component: General → CSS and Themes
Component: CSS and Themes → Shared Components
You need to log in before you can comment on or make changes to this bug.