Closed
Bug 1223701
Opened 9 years ago
Closed 9 years ago
Stop using icon sprites for command buttons
Categories
(DevTools :: Shared Components, defect)
DevTools
Shared Components
Tracking
(firefox45 fixed)
RESOLVED
FIXED
Firefox 45
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: ntim, Assigned: ntim)
References
(Blocks 1 open bug)
Details
(Keywords: addon-compat)
Attachments
(2 files, 3 obsolete files)
12.46 KB,
patch
|
bgrins
:
review+
|
Details | Diff | Splinter Review |
5.24 KB,
patch
|
bgrins
:
review+
|
Details | Diff | Splinter Review |
We can use an SVG filter and CSS opacity to style the icons.
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8686260 -
Flags: review?(bgrinstead)
Assignee | ||
Comment 3•9 years ago
|
||
Fixed issue reported via IRC.
Attachment #8686260 -
Attachment is obsolete: true
Attachment #8686260 -
Flags: review?(bgrinstead)
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8686267 -
Flags: review?(bgrinstead)
Assignee | ||
Updated•9 years ago
|
Attachment #8686265 -
Attachment is obsolete: true
Assignee | ||
Comment 5•9 years ago
|
||
removed an useless rule.
Attachment #8686267 -
Attachment is obsolete: true
Attachment #8686267 -
Flags: review?(bgrinstead)
Attachment #8686270 -
Flags: review?(bgrinstead)
Assignee | ||
Comment 6•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f3dae8726cd2
Assignee | ||
Updated•9 years ago
|
Blocks: dt-theme-cleanup
Comment 7•9 years ago
|
||
This could affect icon display for devtools extensions that register a command button (the buttons on the right, like responsive design mode and split console toggle). The most likely way this would be done is if they registered a new gcli command and also specify a `buttonId` field, then set the image in CSS. I don't know how common this really is, just making sure it's tagged.
Keywords: addon-compat
Comment 8•9 years ago
|
||
Comment on attachment 8686270 [details] [diff] [review] Part 2 - Use CSS to style command button icons (v3.1) Review of attachment 8686270 [details] [diff] [review]: ----------------------------------------------------------------- Works for me, thanks!
Attachment #8686270 -
Flags: review?(bgrinstead) → review+
Updated•9 years ago
|
Attachment #8686259 -
Flags: review?(bgrinstead) → review+
Updated•9 years ago
|
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/85afb22e5dcd https://hg.mozilla.org/integration/fx-team/rev/dfb8a480a4de
Keywords: checkin-needed
Comment 10•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/dfb8a480a4de
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Comment 11•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/85afb22e5dcd
Updated•6 years ago
|
Product: Firefox → DevTools
Assignee | ||
Updated•5 years ago
|
Component: General → CSS and Themes
Updated•2 years ago
|
Component: CSS and Themes → Shared Components
You need to log in
before you can comment on or make changes to this bug.
Description
•