1223747 - Don't assume all frames are visible in XUL documents

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect)

Description

[Seth Fowler [:seth] [:s2h]]

We shouldn't assume all frames are visible when the top-level content document is a XUL document. This is true for mochitests, which means that mochitests are not running in an environment that is comparable to a real web page.

Comment 1

[Seth Fowler [:seth] [:s2h]]

Attachment: Don't assume all frames are visible in XUL documents.

Here's the patch.

Comment 2

[Timothy Nikkel (:tnikkel)]

Background: I originally included XUL docs to make it easier to turn on image visible with less chance of regressions. There wasn't anything specifically blocking turning it on for xul docs, just little upside in enabling it there.

Comment 3

[Seth Fowler [:seth] [:s2h]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8903985055d7

Comment 4

[Seth Fowler [:seth] [:s2h]]

(In reply to Timothy Nikkel (:tn) from comment #2)
> Background: I originally included XUL docs to make it easier to turn on
> image visible with less chance of regressions. There wasn't anything
> specifically blocking turning it on for xul docs, just little upside in
> enabling it there.

Thanks for the review! Based on the try results, it looks like everything went ok.

Comment 5

[Timothy Nikkel (:tnikkel)]

This seems like something that would be good to get landed ASAP, as then any changes it causes can be easily tracked and noticed sooner.

Comment 6

[Seth Fowler [:seth] [:s2h]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5209d6b9fe6e0e39f1b4c46b0642aae3ece65973
Bug 1223747 - Don't assume all frames are visible in XUL documents. r=tn

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5209d6b9fe6e