1223800 - Increase Beta BHR threshold

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Biru [:poiru]]

BHR is enabled on ~1% of the population, but the total number of BHR pings/clients is about 1/10th of Aurora pings/clients. We should increase the threshold to account for this.

Comment 1

[Biru [:poiru]]

Here is the analysis: https://gist.github.com/poiru/5b160327227de16f126c

This is about beta BHR, by the way.

Comment 2

[Vladan Djeric (:vladan)]

Good catch, we'll need this for the Beta A/B experiment

Comment 3

[Chris H-C :chutten]

Attachment: 0001-bug-1223800-Accept-BHR-reports-from-50-of-beta-clien.patch

trypush underway: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c03328d1cbe5

Comment 4

[Chris H-C :chutten]

I've been advised that I was overbroad in my tryjob, so here's the new one: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d54597cdde94

Comment 5

[Vladan Djeric (:vladan)]

Comment on attachment 8687305 [details] [diff] [review]
0001-bug-1223800-Accept-BHR-reports-from-50-of-beta-clien.patch

Approval Request Comment
[Feature/regressing bug #]: None
[User impact if declined]: We need this for an E10S A/B experiment on Beta 43, in order to understand differences in e10s & non-e10s performance.
[Describe test coverage new/current, TreeHerder]: local testing, treeherder
[Risks and why]: Telemetry pings will be larger (this is ok, cleared with Telemetry backend people). BHR is already enabled on 100% of Aurora & Nightly users without any problems.
[String/UUID change made/needed]: None

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Marking affected for the branches where we intend to uplift; I'll check back to make sure this lands

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/0f1f2c377548

Comment 8

[Vladan Djeric (:vladan)]

Uplifted based on a+ via email

https://hg.mozilla.org/releases/mozilla-aurora/rev/76f747a03e69
https://hg.mozilla.org/releases/mozilla-beta/rev/aaa5100e2085

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

This still needs to land on m-c, but it seems ok so far on the other branches. Tomcat, sorry to bug you, does this still  need the checkin-needed flag or would you catch it automatically ?

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/76f747a03e69
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/f23bb8c457e0

Comment 11

[Sylvestre Ledru [:Sylvestre]]

This bug was be fixed only when it will land in m-c.
We use the tracking flags instead for m-b & m-a.

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0f1f2c377548

Comment 13

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8687305 [details] [diff] [review]
0001-bug-1223800-Accept-BHR-reports-from-50-of-beta-clien.patch

Updating the flags, Vladan has already landed the patches if I understand correctly.

Comment 14

[Carsten Book [:Tomcat]]

(In reply to Ritu Kothari (:ritu) from comment #13)
> Comment on attachment 8687305 [details] [diff] [review]
> 0001-bug-1223800-Accept-BHR-reports-from-50-of-beta-clien.patch
> 
> Updating the flags, Vladan has already landed the patches if I understand
> correctly.

yeah via comment #8