Closed Bug 1223800 Opened 4 years ago Closed 4 years ago

Increase Beta BHR threshold

Categories

(Toolkit :: Telemetry, defect)

Unspecified
All
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox43 --- fixed
firefox44 --- fixed
firefox45 --- fixed
b2g-v2.5 --- fixed

People

(Reporter: poiru, Assigned: chutten)

References

Details

Attachments

(1 file)

BHR is enabled on ~1% of the population, but the total number of BHR pings/clients is about 1/10th of Aurora pings/clients. We should increase the threshold to account for this.
Here is the analysis: https://gist.github.com/poiru/5b160327227de16f126c

This is about beta BHR, by the way.
Summary: Increase BHR threshold → Increase Beta BHR threshold
Good catch, we'll need this for the Beta A/B experiment
trypush underway: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c03328d1cbe5
Assignee: nobody → chutten
Status: NEW → ASSIGNED
Attachment #8687305 - Flags: review?(rvitillo)
I've been advised that I was overbroad in my tryjob, so here's the new one: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d54597cdde94
Attachment #8687305 - Flags: review?(rvitillo) → review?(vladan.bugzilla)
Attachment #8687305 - Flags: review?(vladan.bugzilla) → review+
Comment on attachment 8687305 [details] [diff] [review]
0001-bug-1223800-Accept-BHR-reports-from-50-of-beta-clien.patch

Approval Request Comment
[Feature/regressing bug #]: None
[User impact if declined]: We need this for an E10S A/B experiment on Beta 43, in order to understand differences in e10s & non-e10s performance.
[Describe test coverage new/current, TreeHerder]: local testing, treeherder
[Risks and why]: Telemetry pings will be larger (this is ok, cleared with Telemetry backend people). BHR is already enabled on 100% of Aurora & Nightly users without any problems.
[String/UUID change made/needed]: None
Attachment #8687305 - Flags: approval-mozilla-beta?
Attachment #8687305 - Flags: approval-mozilla-aurora?
Keywords: checkin-needed
Marking affected for the branches where we intend to uplift; I'll check back to make sure this lands
Uplifted based on a+ via email

https://hg.mozilla.org/releases/mozilla-aurora/rev/76f747a03e69
https://hg.mozilla.org/releases/mozilla-beta/rev/aaa5100e2085
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
This still needs to land on m-c, but it seems ok so far on the other branches. Tomcat, sorry to bug you, does this still  need the checkin-needed flag or would you catch it automatically ?
Flags: needinfo?(cbook)
This bug was be fixed only when it will land in m-c.
We use the tracking flags instead for m-b & m-a.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/mozilla-central/rev/0f1f2c377548
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Comment on attachment 8687305 [details] [diff] [review]
0001-bug-1223800-Accept-BHR-reports-from-50-of-beta-clien.patch

Updating the flags, Vladan has already landed the patches if I understand correctly.
Attachment #8687305 - Flags: approval-mozilla-beta?
Attachment #8687305 - Flags: approval-mozilla-beta+
Attachment #8687305 - Flags: approval-mozilla-aurora?
Attachment #8687305 - Flags: approval-mozilla-aurora+
(In reply to Ritu Kothari (:ritu) from comment #13)
> Comment on attachment 8687305 [details] [diff] [review]
> 0001-bug-1223800-Accept-BHR-reports-from-50-of-beta-clien.patch
> 
> Updating the flags, Vladan has already landed the patches if I understand
> correctly.

yeah via comment #8
Flags: needinfo?(cbook)
You need to log in before you can comment on or make changes to this bug.