1223890 - Constraint errors in history panel

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Brian Nicholson (:bnicholson)]

When selecting the history panel:

2015-11-11 10:20:05.343 Client[16187:968175] Unable to simultaneously satisfy constraints.
	Probably at least one of the constraints in the following list is one you don't want. 
	Try this: 
		(1) look at each constraint and try to figure out which you don't expect; 
		(2) find the code that added the unwanted constraint or constraints and fix it. 
(
    "<SnapKit.LayoutConstraint:0x7fb6ea620d70@/Users/brian/mozilla/ios/Client/Frontend/Widgets/SiteTableViewController.swift#55 UILabel:0x7fb6e85f8030.left == _UITableViewHeaderFooterContentView:0x7fb6e85e9ae0.left + 10.0>",
    "<SnapKit.LayoutConstraint:0x7fb6ea621c50@/Users/brian/mozilla/ios/Client/Frontend/Widgets/SiteTableViewController.swift#55 UILabel:0x7fb6e85f8030.right == _UITableViewHeaderFooterContentView:0x7fb6e85e9ae0.right - 10.0>",
    "<NSLayoutConstraint:0x7fb6ea622b30 'UIView-Encapsulated-Layout-Width' H:[_UITableViewHeaderFooterContentView:0x7fb6e85e9ae0(0)]>"
)

Will attempt to recover by breaking constraint 
<SnapKit.LayoutConstraint:0x7fb6ea621c50@/Users/brian/mozilla/ios/Client/Frontend/Widgets/SiteTableViewController.swift#55 UILabel:0x7fb6e85f8030.right == _UITableViewHeaderFooterContentView:0x7fb6e85e9ae0.right - 10.0>

Make a symbolic breakpoint at UIViewAlertForUnsatisfiableConstraints to catch this in the debugger.
The methods in the UIConstraintBasedLayoutDebugging category on UIView listed in <UIKit/UIView.h> may also be helpful.

Comment 1

[Johannes Marbach]

Attachment: Pull request

The section header views are initially created with a zero width and height which conflicts with the required leading and trailing space around the title label. Reducing the priority of constraints kills the warnings on the console.

Comment 2

[Brian Nicholson (:bnicholson)]

Comment on attachment 8687671 [details] [review]
Pull request

Thanks for fixing this! Just a couple comments in the PR.

Comment 3

[Aaron Train [:aaronmt]]

Still see this on master

Comment 4

[Johannes Marbach]

Thanks for reviewing Brian. I adapted the PR based on your comments. Is there anything else I should do?

Comment 5

[Brian Nicholson (:bnicholson)]

Comment on attachment 8687671 [details] [review]
Pull request

Ah, this fell of my radar -- thanks for flagging me! Fix looks good to me :)

Comment 6

[Brian Nicholson (:bnicholson)]

https://github.com/mozilla/firefox-ios/commit/889206b78548fb7e5584e143179ee4ee689de07d