1223907 - Add Cookie body not encapsulated in cookie field

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Titus Fortner]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/48.0.2561.0 Safari/537.36

Steps to reproduce:

This works:    >>> http://localhost:4446/session/0c18d086-e1a8-c34f-bcf6-637c769f8003/cookie | {"name":"foo","value":"bar","path":"/","secure":false}

but is not correct according to the spec: http://www.w3.org/TR/webdriver/#get-cookie

This is correct and does not work:
   >>> http://localhost:4446/session/62e70c59-6d97-004f-863c-29c258611d77/cookie | {"cookie":{"name":"foo","value":"bar","path":"/","secure":false}}



Actual results:

{"error":"invalid argument","message":"Missing 'name' parameter"}


Expected results:

success response and gets added

Comment 1

[Andreas Tolfsen ❲:ato❳]

According to the specification, the body sent to Add Cookie should be encapsulated in a "cookie" field: https://w3c.github.io/webdriver/webdriver-spec.html#add-cookie

The expected input is: {"cookie": <cookie>}

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: MozReview Request: Bug 1223907: Refactor cookies in Marionette

Bug 1223907: Refactor cookies in Marionette

Moves most of the cookie implementation to a new file,
testing/marionette/cookies.js.  The new Cookies class encapsulates all
APIs for manipulating and querying cookies from content space.

It communicates with chrome space, where the cookie manager lives, through
a new SyncContentSender provided by testing/marionette/proxy.js.  This new
interface provides synchronous and transparent communication from content
to chrome, not dissimilar from how the original listener proxy works.

r=dburns

Comment 3

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8687168 [details]
MozReview Request: Bug 1223907: Refactor cookies in Marionette

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25125/diff/1-2/

Comment 4

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8687168 [details]
MozReview Request: Bug 1223907: Refactor cookies in Marionette

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25125/diff/1-2/

Comment 5

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8687168 [details]
MozReview Request: Bug 1223907: Refactor cookies in Marionette

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25125/diff/2-3/

Comment 6

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8687168 [details]
MozReview Request: Bug 1223907: Refactor cookies in Marionette

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25125/diff/3-4/

Comment 7

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8687168 [details]
MozReview Request: Bug 1223907: Refactor cookies in Marionette

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25125/diff/4-5/

Comment 8

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8687168 [details]
MozReview Request: Bug 1223907: Refactor cookies in Marionette

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25125/diff/5-6/

Comment 9

[David Burns :automatedtester]

Comment on attachment 8687168 [details]
MozReview Request: Bug 1223907: Refactor cookies in Marionette

https://reviewboard.mozilla.org/r/25125/#review22649

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e4cc1ebf67ee

Comment 11

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3d4832835b25

Comment 12

[Andreas Tolfsen ❲:ato❳]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4fbb4c6cf33e&group_state=expanded

Comment 13

[Andreas Tolfsen ❲:ato❳]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=da1105afc754

Comment 14

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8687168 [details]
MozReview Request: Bug 1223907: Refactor cookies in Marionette

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25125/diff/6-7/

Comment 15

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8687168 [details]
MozReview Request: Bug 1223907: Refactor cookies in Marionette

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25125/diff/7-8/

Comment 16

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8687168 [details]
MozReview Request: Bug 1223907: Refactor cookies in Marionette

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25125/diff/8-9/

Comment 17

[Andreas Tolfsen ❲:ato❳]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=df993f1f5926&group_state=expanded

Comment 18

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8687168 [details]
MozReview Request: Bug 1223907: Refactor cookies in Marionette

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25125/diff/9-10/

Comment 19

[Andreas Tolfsen ❲:ato❳]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=14070cb1b989&group_state=expanded

Comment 20

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ca54275a013d

Comment 21

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ca54275a013d