Closed
Bug 1223990
Opened 9 years ago
Closed 9 years ago
Throwing errors in self-hosted code asserts in Error prototype creation
Categories
(Core :: JavaScript: Standard Library, defect)
Core
JavaScript: Standard Library
Tracking
()
RESOLVED
FIXED
mozilla45
| Tracking | Status | |
|---|---|---|
| firefox45 | --- | fixed |
People
(Reporter: efaust, Assigned: efaust)
References
Details
Attachments
(1 file)
|
1.13 KB,
patch
|
till
:
review+
|
Details | Diff | Splinter Review |
We can't throw a syntax error (or any error) in self-hosted code, because we cannot construct the Error constructor, as it relies on self-hosted code.
Since none of these errors are accessible to script, we should just ensure that we instead just report the error immediately.
Attachment #8686271 -
Flags: review?(till)
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → efaustbmo
Status: NEW → ASSIGNED
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8686271 [details] [diff] [review]
Fix
Review of attachment 8686271 [details] [diff] [review]:
-----------------------------------------------------------------
Very nice!
Attachment #8686271 -
Flags: review?(till) → review+
|
||
Comment 3•9 years ago
|
||
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/eb1b4bf6d857 for mass bustage - https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=ee68d52994d9&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-failure_classification_id=2 should mostly be this
|
||
Comment 5•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in
before you can comment on or make changes to this bug.
Description
•