Closed Bug 1223990 Opened 6 years ago Closed 6 years ago

Throwing errors in self-hosted code asserts in Error prototype creation

Categories

(Core :: JavaScript: Standard Library, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: efaust, Assigned: efaust)

References

Details

Attachments

(1 file)

Attached patch FixSplinter Review
We can't throw a syntax error (or any error) in self-hosted code, because we cannot construct the Error constructor, as it relies on self-hosted code.

Since none of these errors are accessible to script, we should just ensure that we instead just report the error immediately.
Attachment #8686271 - Flags: review?(till)
Assignee: nobody → efaustbmo
Status: NEW → ASSIGNED
Comment on attachment 8686271 [details] [diff] [review]
Fix

Review of attachment 8686271 [details] [diff] [review]:
-----------------------------------------------------------------

Very nice!
Attachment #8686271 - Flags: review?(till) → review+
https://hg.mozilla.org/mozilla-central/rev/582d73c412f6
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.