All users were logged out of Bugzilla on October 13th, 2018

Throwing errors in self-hosted code asserts in Error prototype creation

RESOLVED FIXED in Firefox 45

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: efaust, Assigned: efaust)

Tracking

unspecified
mozilla45
Points:
---

Firefox Tracking Flags

(firefox45 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8686271 [details] [diff] [review]
Fix

We can't throw a syntax error (or any error) in self-hosted code, because we cannot construct the Error constructor, as it relies on self-hosted code.

Since none of these errors are accessible to script, we should just ensure that we instead just report the error immediately.
Attachment #8686271 - Flags: review?(till)
(Assignee)

Updated

3 years ago
Assignee: nobody → efaustbmo
Status: NEW → ASSIGNED
Comment on attachment 8686271 [details] [diff] [review]
Fix

Review of attachment 8686271 [details] [diff] [review]:
-----------------------------------------------------------------

Very nice!
Attachment #8686271 - Flags: review?(till) → review+

Comment 5

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/582d73c412f6
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.