Closed Bug 1224029 Opened 9 years ago Closed 8 years ago

Intermittent test_peerConnection_trackDisabling.html | Test timed out.

Categories

(Core :: WebRTC, defect, P1)

Product:
Core
Component:
WebRTC
Version:
45 Branch
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla48
Tracking Flags:
Tracking Status
firefox45 --- wontfix
firefox46 --- fixed
firefox47 --- fixed
firefox48 --- fixed
firefox-esr45 --- fixed
Blocking Flags:
backlog webrtc/webaudio+

People

(Reporter: KWierso, Assigned: jesup)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

ensure video elements that may be disabled (black) are scaled
4.70 KB, patch
mattwoodrow
: review+
Details | Diff | Splinter Review
backlog: --- → webrtc/webaudio+
Rank: 35
Priority: -- → P3
This is the #2 top orange overall. Can somebody please take a look?
Flags: needinfo?(mreavy)
Short answer: Yes.  Longer answer: I plan to do a full scrub of the orange factor list next week and get folks looking at all our (WebRTC/Web Audio) top oranges.  (I realize there are more than just this one.)  We had been doing pretty well on the orange factor for a while, but we've landed a lot of code recently -- which has changed the timing.  Some of my team is on PTO this week, and uplift is Monday.  So I can't make this a top priority this week, but after this week, I'll get folks looking at this and all the others so that by the end of March we've driven our orange count way down.
Flags: needinfo?(mreavy)
Talked with mreavy about this.

I'm working on this one; I have a failure caught in rr, so I have hope to fix this soon.
Assignee: nobody → rjesup
Rank: 35 → 10
Flags: needinfo?(mreavy)
Priority: P3 → P1
Cause is that a disabled track *may* render as a 1x1 black image, and drawImage(video, 0, 0) doesn't scale, so we get 1x1 black and sample pixel 50,50 (which is still green) -> timeout
Attachment #8728109 - Flags: review?(matt.woodrow)
Attachment #8728109 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/mozilla-central/rev/0306c8c95d42
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Comment on attachment 8728109 [details] [diff] [review]
ensure video elements that may be disabled (black) are scaled

Approval Request Comment
[Feature/regressing bug #]: N/A

[User impact if declined]: Test failures that need to be starred frequently

[Describe test coverage new/current, TreeHerder]: This is a fix for a broken/racy test.  No failures reported since this landed (in trees with the patch) from what I can see

[Risks and why]: No risk to the product, purely a test script change

[String/UUID change made/needed]: none
Attachment #8728109 - Flags: approval-mozilla-beta?
Attachment #8728109 - Flags: approval-mozilla-aurora?
Attachment #8728109 - Flags: approval-mozilla-aurora?
Comment on attachment 8728109 [details] [diff] [review]
ensure video elements that may be disabled (black) are scaled

Test-only changes don't need approval :)
Attachment #8728109 - Flags: approval-mozilla-beta?
Whiteboard: [checkin-needed-beta]
status-firefox-esr45: --- → affected
Whiteboard: [checkin-needed-beta] → [checkin-needed-esr45]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: