Closed
Bug 1224044
Opened 9 years ago
Closed 9 years ago
Use stable hashing in SavedFramePtrHasher
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla45
| Tracking | Status | |
|---|---|---|
| firefox45 | --- | fixed |
People
(Reporter: terrence, Assigned: jonco)
References
Details
Attachments
(1 file)
|
2.31 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
Probably not difficult, but I haven't looked in any detail.
|
||
Comment 1•9 years ago
|
||
ISTR, there was an issue where the various TraceableFoo structures didn't support HashSets that are semantically a map but the lookup is member of the value. Not sure if this smart/stable hashing is orthogonal to that or not.
|
Assignee | |
Comment 2•9 years ago
|
||
With stable hashing, we don't have to rekey when the parent gets moved. Again, only tested locally so far.
Assignee: nobody → jcoppeard
Attachment #8686617 -
Flags: review?(terrence)
|
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8686617 [details] [diff] [review]
bug1224044-stable-hashing-saved-frame-ptr
Review of attachment 8686617 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/vm/SavedStacks.cpp
@@ -1055,5 @@
> - SavedFrame::Lookup newLocation(*frame);
> - newLocation.parent = parent;
> - e.rekeyFront(newLocation, ReadBarriered<SavedFrame*>(frame));
> - }
> - }
\o/ so nice to get rid of all of this!
|
Reporter | |
Comment 4•9 years ago
|
||
Comment on attachment 8686617 [details] [diff] [review]
bug1224044-stable-hashing-saved-frame-ptr
Review of attachment 8686617 [details] [diff] [review]:
-----------------------------------------------------------------
Nice!
Attachment #8686617 -
Flags: review?(terrence) → review+
|
||
Comment 6•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in
before you can comment on or make changes to this bug.
Description
•