1224067 - Updated German Holidays until 2025

Status: RESOLVED WORKSFORME

(Calendar :: Website, defect)

Description

[Hagen Halbach [:Fux]]

Attachment: German Holidays 2010-2025

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:42.0) Gecko/20100101 Firefox/42.0
Build ID: 20151029151421

Steps to reproduce:

I did an update to my outdated holiday file at https://www.mozilla.org/en-US/projects/calendar/holidays/#G (German), file is attachend.

Thanks for adding!

Comment 3

[Peter Weilbacher]

Why does it take so long to get this onto the webpage? The current calendar is missing dates from 2016 which is about to begin.

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/5de7c20cff8e4d2d21fb1240993144b763ca0281
Update GermanHolidays.ics

Bug 1224067 - Updated German Holidays until 2025

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/cb696512e297a9359ba3c2bdbeb700313df541e1
Fix bug 1224067 - Updated German Holidays until 2025

Comment 7

[Stephan Petersen]

https://www.mozilla.org/media/caldata/GermanHolidays.ics is still not up-to-date, what's going on?

Comment 8

[boe]

Hai ;-) Stephan,

this is the old file - Fux's attachment is correct!

Comment 9

[Stephan Petersen]

Hi, ahh, ok, thanks, good thing Easter won't be cancelled this year after all :-)

Comment 10

[boe]

High ;-) Stephan, 

no, God and Commissioner Oettinger haven't canceled Easter! If you need another calendars AT/CH/DE/LI (German) - blink to [https://www.thunderbird-mail.de/thread/72064-frische-kalender-f%C3%BCr-de-li-at-ch-2010-2030/]. My Calendars die in the queue named Bugzilla@Mozilla. 

I wish you a nuclear-free 2016!

Comment 11

[Peter Weilbacher]

(In reply to boe from comment #8)
> this is the old file - Fux's attachment is correct!

Eh... It was the whole point of this bug which is now resolved to update that file with the attachment here. Obviously that didn't work with the commit given in comment 5-- no idea why and no idea who told the github robot to do it, so no idea who to CC, but I'm reopening this bug. The webpage seems to be changed (it now says 2010-2025), just the file linked was not.

Comment 12

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

The robot commented because the PR that Fux made was merged, see:


https://github.com/mozilla/bedrock/pull/3706
https://github.com/mozilla/bedrock/pull/3707

Fux has asked on the PR why this didn't work, I assume some sort of caching or production merge that needs to happen.

Comment 13

[Hagen Halbach [:Fux]]

Now it's working, thanks.

Fallen was right:

"These static files are served from a CDN and cached for 30 days, but we've purged the cache manually so the updated file should be serving now. Some browsers/clients may have their own cache, of course, so there's not much we can do about that.

We may shorten the expiration time for calendar files to just a few days so updates become available quicker in the future."