1224080 - [EME] Attaching MediaKeys before MediaSource causes load failure

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Testcase; should see sourceopen event, but we see error

If we set a MediaKeys on an HTMLMediaElement before we attach the MediaSource, when we attach the MediaSource the load fails.

It's because our check in HTMLMediaElement::LoadResource() to ensure we only use EME if we're loading an MSE URL is actually check if we're loading a MediaStream URI, not a MediaSource URI:

http://hg.mozilla.org/mozilla-central/file/a8ed7dd831d1/dom/html/HTMLMediaElement.cpp#l1238

D'oh!

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

This bug has been here ever since we restricted EME to MSE; bug 1131392.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch: Ensure attaching MediaKeys before MediaSource doesn't cause load failure

Fixup the check that is supposed to prevent non MSE loads when we have a MediaKeys attached to actually check that we have a MSE URI instead of a MediaStream URI.

With test!

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8686399 [details] [diff] [review]
Patch: Ensure attaching MediaKeys before MediaSource doesn't cause load failure

Review of attachment 8686399 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with femto-nit (I had to complain about something).

::: dom/media/test/test_eme_setMediaKeys_before_attach_MediaSource.html
@@ +12,5 @@
> +<script class="testbody" type="text/javascript">
> +
> +function beginTest() {
> +  var video = document.createElement("video");
> +  

Spaces on empty line.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4a2071b4d965

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/4a2071b4d965