1224083 - Adding string preferences from file adds «u» before «'value'»

Status: RESOLVED FIXED

(Testing :: mozregression, defect)

Description

[arni2033]

Attachment: mozregression - Dark theme 2015.11.12 05-34-20.json

STR:   (Win7_64, Nightly 45, 32bit, ID 20151110030205, new profile)
1. Save attached file "mozregression - Dark theme"
2. Start new bisection, in the 3rd screen click "Add preferences from file", choose file from Step 1

Result:                 +------------------+-----------+
 The table says:        |  devtools.theme  |  u'dark'  |
                        +------------------+-----------+
Expectations:
 The value should be «'dark'», not «u'dark'»

Comment 1

[Julien Pagès (:parkouss)]

Right, this is only a display issue, because of the repr() function used there:

https://github.com/mozilla/mozregression/blob/2a7ad984bf7b42d0c720c4c8276a178869af0a3f/gui/mozregui/pref_editor.py#L33

BTW I saw a real issue there: https://github.com/mozilla/mozregression/blob/2a7ad984bf7b42d0c720c4c8276a178869af0a3f/gui/mozregui/pref_editor.py#L39 where we use str() instead of unicode. That means that we can not entre manually a non ascii char and we should fix that.

This is a simple bug, let's see if someone is interested to get started with.

Comment 2

[Vaibhav Tulsyan [:xenny]]

I am interested in resolving this bug. At this moment, I am trying to reproduce it on my machine:
Ubuntu 14.04 - 2, 64 bit.

Comment 3

[Julien Pagès (:parkouss)]

Sure! So we talked on irc, issue reproduced.

Thanks Vaibhav for tackling this bug!

Comment 4

[Vaibhav Tulsyan [:xenny]]

Attachment: Fix Unicode display and edit

Comment 5

[Julien Pagès (:parkouss)]

So yeah, almost here - just the review flag is not set. To do that now:

 - Click on [details]
 - select "?" for the review field
 - in the new textbox displayed, copy my email address (or hit :parkouss and choose what the completion offer)
 - click submit

Thanks!

Comment 6

[Julien Pagès (:parkouss)]

Comment on attachment 8686624 [details] [review]
Fix Unicode display and edit

Thanks! Looks good to me. I think we can simplify it a bit more (see my comment).

Tell me when you made the change, or if that can not be applicable for some reason. thanks!

Comment 7

[Julien Pagès (:parkouss)]

Oh also, I you know how to squash your commits, please do it. Else I can do that, and I can explain you how to do that later on irc for next time.

Comment 8

[Julien Pagès (:parkouss)]

Landed in https://github.com/mozilla/mozregression/commit/ff6867f7e6ac296bf8ced8fb19e4d460898b8029.

Thanks Vaibhav. :)