1224085 - Waiting for states in "initialization" of Mobileconnection marionette-webapi tests

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: RIL, defect)

Description

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Before each test starts, we will call "ensureMobileConnection()" in head.js to make sure "mobileconnection instance" is created without problems. That's still not enough because it's possible that radio state, registration state , ... are not ready. The safer way is that we need to explicitly wait for those states being ready before executing the real tests.


[1] https://dxr.mozilla.org/mozilla-central/source/dom/mobileconnection/tests/marionette/head.js#245

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=97f102fc233a

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: 1224085.patch

Wait for mozMobileConnection initialization thoroughly completes before aTestCaseMain runs.

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=51299e029805

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

https://treeherder.allizom.org/#/jobs?repo=try&revision=77e202b6439b

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8687101 [details] [diff] [review]
1224085.patch

Hi Edgar,
Comment 4 shows positive try results. Could you help review this? Thank you!

Comment 6

[Edgar Chen [:edgar]]

Comment on attachment 8687101 [details] [diff] [review]
1224085.patch

Review of attachment 8687101 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, just one thing, please see my comment below. Thank you.

::: dom/mobileconnection/tests/marionette/head.js
@@ +303,5 @@
> + */
> +function ensureMobileConnectionInitialStates(aServiceId) {
> +  let mobileConn = getMozMobileConnectionByServiceId(aServiceId);
> +  if (mobileConn.radioState === "enabled" &&
> +      !!mobileConn.iccId && mobileConn.voice.connected) {

What if |radioState| is "enabled", but iccId isn't ready yet (e.g. ril is still processing icc io), then we still wait "radiostatechange" event which won't be sent actually in line#313. IMO, we should check status to decide whether we need to wait the event (same for |iccId| and |voice.connected|).

Comment 7

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Considering the Tier3 situation, I got the impression that we won't fix this.