Closed
Bug 1224135
Opened 9 years ago
Closed 9 years ago
Fix the wrong comment for |TelemetryController.assemblePing|
Categories
(Toolkit :: Telemetry, defect, P4)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla45
| Tracking | Status | |
|---|---|---|
| firefox45 | --- | fixed |
People
(Reporter: Dexter, Assigned: spillmas, Mentored)
References
(Blocks 1 open bug)
Details
(Whiteboard: [measurement:client][lang=js][good first bug])
Attachments
(1 file)
|
1.49 KB,
patch
|
Dexter
:
review+
|
Details | Diff | Splinter Review |
Bug 1140558 changed the behaviour of TelemetryController.assemblePing but the comments do not reflect the new behaviour.
We should change [0]: we're not returning a promise any more, we're directly returning the ping data.
[0] - https://dxr.mozilla.org/mozilla-central/rev/84a7cf29f4f14c9b359db2f7f19c0abd6a8e178e/toolkit/components/telemetry/TelemetryController.jsm#445
|
Reporter | |
Updated•9 years ago
|
|
|
Reporter | |
Updated•9 years ago
|
Mentor: alessio.placitelli, gfritzsche
Whiteboard: [measurement:client] → [measurement:client][lang=js][good first bug]
Hey, I've attached a patch. I hope that's somewhat the change you were looking for?
Attachment #8687913 -
Flags: review?(alessio.placitelli)
|
|
Reporter | |
Comment 2•9 years ago
|
||
Comment on attachment 8687913 [details] [diff] [review]
First attempt - change comment.
Review of attachment 8687913 [details] [diff] [review]:
-----------------------------------------------------------------
This looks good, thank you for your patch submission.
Since this only a comment changing, there's no need to push to the try servers.
Attachment #8687913 -
Flags: review?(alessio.placitelli) → review+
|
|
Reporter | |
Updated•9 years ago
|
Keywords: checkin-needed
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in
before you can comment on or make changes to this bug.
Description
•