1224136 - The pin site icon can not be shown correctly on the homescreen.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect, P2)

Description

[zouyi(Leave from Mozilla)]

Attachment: Bug log: logcat_1550.txt

[1.Description]:
[Aries KK_v2.6&v2.5][Flame KK_v2.6&v2.5]When you pin site in landscape mode of browser, the icon on homescreen is too big.

See attchment:Aries KK_v2.6.3gp&logcat_1550.txt
Found Time: 15:50

[2.Testing Steps]: 
1. Launch the browser.
2. Switch to landscape mode.
3. Tap the menu of browser at the top right.
4. Tap ''pin site'' button.
5. Tap home button.
6. Observe the pin icon.

[3.Expected Result]: 
6. The pin icon is shown correctly.

[4.Actual Result]: 
6. The pin icon is too big.

[5.Reproduction build]: 
Device: Flame KK v2.6(master)(Affected)
Build ID               20151111150236
Gaia Revision          22f8023b112dfae83531b0a075ab9eb9a5444dfa
Gaia Date              2015-11-10 23:35:38
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/84a7cf29f4f14c9b359db2f7f19c0abd6a8e178e
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151111.182640
Firmware Date          Wed Nov 11 18:26:52 EST 2015
Bootloader             L1TC000118D0

Device: Flame KK v2.5 512mb (Affected)
Build ID               20151109004552
Gaia Revision          cf646c52bb947af28329b0a100df91d1b1f2a907
Gaia Date              2015-11-09 02:55:50
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/4eafef5b80f8985c94c4a067f130d37513e1a581
Gecko Version          44.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151109.041411
Firmware Date          Mon Nov  9 04:14:26 EST 2015
Firmware Version        V18D V4
Bootloader             L1TC000118D0

Device: Aries KK v2.6(master)(Affected)
Build ID               20151111124419
Gaia Revision          22f8023b112dfae83531b0a075ab9eb9a5444dfa
Gaia Date              2015-11-10 23:35:38
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/84a7cf29f4f14c9b359db2f7f19c0abd6a8e178e
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151111.120325
Firmware Date          Wed Nov 11 12:03:33 UTC 2015
Bootloader             s1

Device: Aries KK v2.5(Affected) 
Build ID               20151110094357
Gaia Revision          07baf613699fa6225359c7f04825c5caeb71d424
Gaia Date              2015-11-09 21:32:50
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/e14287b00a514a15418dfaa89287030c588ad19d
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151110.090331
Firmware Date          Tue Nov 10 09:03:39 UTC 2015
Bootloader             s1

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]:
Free Test

Comment 1

[zouyi(Leave from Mozilla)]

Attachment: Bug video: Aries KK_v2.6.3gp

Comment 2

[Chris Lord [:cwiiis]]

[Blocking Requested - why for this release]: Core feature can be made to look pretty broken.

Nice find :) I'll take this...

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] Cwiiis:bug1224136-homescreen-pin-landscape-big-icons > mozilla-b2g:master

Comment 4

[Chris Lord [:cwiiis]]

Comment on attachment 8687195 [details] [review]
[gaia] Cwiiis:bug1224136-homescreen-pin-landscape-big-icons > mozilla-b2g:master

This changes up the icon sizing code to be a bit more robust, but also less wasteful.

I believe this also fixes bug 1220186 and bug 1215553 - it knocks off ~2 seconds off fullyLoaded time (tested over two 30-run trials), which puts our fullyLoaded time within a second of verticalhome. There are still savings to be made, but I'd say it's in an acceptable place now.

Comment 5

[Chris Lord [:cwiiis]]

Comment on attachment 8687195 [details] [review]
[gaia] Cwiiis:bug1224136-homescreen-pin-landscape-big-icons > mozilla-b2g:master

Moving review to Michael, Alberto and Guillaume are on PTO.

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8687195 [details] [review]
[gaia] Cwiiis:bug1224136-homescreen-pin-landscape-big-icons > mozilla-b2g:master

I left a couple of comments on github, but neither of them will block since they are nits.

Comment 7

[Chris Lord [:cwiiis]]

nit fixed and merged: https://github.com/mozilla-b2g/gaia/commit/647408a670917484a35856d70d0bce40afe73017

Comment 8

[Chris Lord [:cwiiis]]

Comment on attachment 8687195 [details] [review]
[gaia] Cwiiis:bug1224136-homescreen-pin-landscape-big-icons > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: You can get icons to temporarily lay out bigger than they should
[Testing completed]: Manual testing completed
[Risk to taking this patch] (and alternatives if risky): Low-medium risk of different icon layout glitches. Shouldn't be uplifted without bug 1222340.
[String changes made]: None

Comment 9

[Mahendra Potharaju [:mahe]]

Comment on attachment 8687195 [details] [review]
[gaia] Cwiiis:bug1224136-homescreen-pin-landscape-big-icons > mozilla-b2g:master

Approved for 2.5 uplift. 

Thanks

Comment 10

[Alissa（leave from Mozilla）]

This bug has been verfied as pass on latest build of Flame KK v2.6 512mb(master) and Aries KK 2.6(master) by the STR in comment 0.
Actual  results: The pin icon on homescreen is shown correctly.
See attachment: verified_Aries_v2.6(master).3gp
Reproduce rate: 0/10

Device:Flame KK v2.6 512mb(master) (Pass)
Build ID               20151118150206
Gaia Revision          cba7e4b86361af31b153cfebaf99900e0b860f7b
Gaia Date              2015-11-18 09:45:49
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/1d6155d7e6c91fa5ec1ef6927f3d3a044187896d
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151118.184005
Firmware Date          Wed Nov 18 18:40:17 EST 2015
Firmware Version        V18D V4
Bootloader             L1TC000118D0

Device:Aries KK v2.6(master) (Pass)
Build ID               20151118150439
Gaia Revision          cba7e4b86361af31b153cfebaf99900e0b860f7b
Gaia Date              2015-11-18 09:45:49
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/1d6155d7e6c91fa5ec1ef6927f3d3a044187896d
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151118.142334
Firmware Date          Wed Nov 18 14:23:42 UTC 2015
Bootloader             s1

Comment 11

[Alissa（leave from Mozilla）]

Attachment: verified_Aries_v2.6(master).3gp

Comment 12

[Carsten Book [:Tomcat]]

for 2.5 https://github.com/mozilla-b2g/gaia/commit/7726bfd621d709fa2d179704a44aebc1c309c296

Comment 13

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame 2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: the pin site icon on homescreen is not big and shows normally. 
See attachment: verified_Aries_v2.5.3gp
Reproduce rate: 0/10


Device: Aries KK v2.5 (Pass)
Build ID               20151125233358
Gaia Revision          93b8bf2de3258c25199d97036c50a87667059148
Gaia Date              2015-11-25 10:29:48
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/a883c12a75da3fa58b64bcb94923b013c71f546a
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151125.224212
Firmware Date          Wed Nov 25 22:42:20 UTC 2015
Bootloader             s1

Device: Flame 2.5 (512mb) (Pass)
Build ID               20151125234005
Gaia Revision          93b8bf2de3258c25199d97036c50a87667059148
Gaia Date              2015-11-25 10:29:48
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/a883c12a75da3fa58b64bcb94923b013c71f546a
Gecko Version          44.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151125.224957
Firmware Date          Wed Nov 25 22:50:06 UTC 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Comment 14

[Shally Li（leave from Mozilla）]

Attachment: verified_Aries_v2.5.3gp