1224196 - [devtools] Do Not word-wrap labels on toolbar in Memory tool

Status: RESOLVED FIXED

(DevTools :: Memory, defect)

Description

[magicp]

Attachment: devtools-memory-word-wrap.png

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20151111030207

Steps to reproduce:

1. Run Nightly (or Aurora)
2. Open devtools > Memory
3. Firefox window width to narrow


Actual results:

Labels on toolbar is word-wrapped.


Expected results:

Do Not word-wrap labels on toolbar in Memory tool.

Comment 1

[Tim Nguyen :ntim]

You need to add white-space: nowrap;overflow: hidden;text-overflow: ellipsis; here (with the correct indentation and line breaks): https://dxr.mozilla.org/mozilla-central/source/devtools/client/themes/memory.css#74 to fix this bug.

Comment 2

[Sunny Sidhu]

Attachment: rev1 - Applies changes to fix word wrap in toolbar-group for devtools

Hi Tim, 

I've had a go at this. Please can you provide feedback on my patch?

Comment 3

[Sunny Sidhu]

Attachment: rev1_test.png

I've tested the changes using the Browser Toolbox, see attached.

Comment 4

[magicp]

(In reply to Sunny Sidhu from comment #3)
> Created attachment 8688363 [details]
> rev1_test.png
> 
> I've tested the changes using the Browser Toolbox, see attached.

It seems snapshot icon is gone !?

Comment 5

[Sunny Sidhu]

Attachment: rev2_test2.PNG

(In reply to magicp from comment #4)
> It seems snapshot icon is gone !?
Strange, I've no idea. All seems to be well on my re-test, see attached.

Comment 6

[magicp]

(In reply to Sunny Sidhu from comment #5)
> Strange, I've no idea. All seems to be well on my re-test, see attached.
Your re-test is good. Thanks!

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/e4fab7d5c909

Comment 8

[Sunny Sidhu]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=331b2fa459aa

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e4fab7d5c909