1224278 - Hide client records that are likely to be duplicates or stale in Fennec Send to Device list

Status: RESOLVED DUPLICATE of bug 1351104

(Firefox for Android Graveyard :: Data Providers, defect)

Description

[Nick Alexander :nalexander [he/him]]

Bug 1180287 added some filtering to the list of clients displayed in the Synced Tabs panel.  ckolos reports an issue: it looks like we missed adding that filtering to the Send Tab / Send to Device list.  (I thought this would Just Work, but it may not.)  This ticket tracks using the same query to populate the Send Tab dialog list as well.

Comment 1

[Nick Alexander :nalexander [he/him]]

Ahmed: can you investigate this?  I've tracked the query back to https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/overlays/service/sharemethods/SendTab.java#258, which might need to be updated.

Thanks!

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I've had the devices in the Send Tab to Device list be filtered before but now it seems like it might be broken (i.e. afaik, I didn't change anything but my current device shows up as a duplicate in the device list).

Comment 3

[Ahmed Khalil]

Hi Nick,

I'm pretty sure that the SendTab dialog displays the expected devices, actually while I was developing on  Bug 1180287, I always made sure that it worked on the SendTab dialog first, then verified the code on the Synced Tabs Panel.

I doubt that this issue is related to the filtering code in Bug 1180287.

I checked also Fennec latest build, and both the Synced Tabs Panel and the SendTab dialog displays the same set of devices.

Comment 4

[swaroop.rao]

Is this bug still valid, based on comment 3 above? If so, I'd like to take a stab at looking into it. I have a build that is ready to go and I've submitted 3 defects for code review recently.

Comment 5

[:Grisha Kruglov]

We're doing some work to improve data behind this list, so duping this bug against a meta one.