1224316 - Possibly don't show "TEST-UNEXPECTED-FAIL" in the failure summary panel if they occurred in the "Using buildbot properties" section of the log?

Status: RESOLVED DUPLICATE of bug 1188351

(Tree Management :: Treeherder, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

If someone adds "TEST-UNEXPECTED-FAIL" to a commit message (when fixing or backing out something for a failure, for instance), Treeherder includes those lines into the failure summary panel because buildbot properties include recent commit messages, in the push that included the commit message AND in several of the pushes that follow it.

I'm not sure how difficult it would be for Treeherder to ignore (or just not surface) those lines from the failure summary panel if they happen in that buildbot properties section of the log (and it's probably easier to just tell people not to include magic phrases like "TEST-UNEXPECTED-FAIL" in their commit messages, but I thought I'd file this anyway since it happened today and was bugging me a bit.

Comment 1

[Ed Morley [:emorley]]

The best solution would be to not dump the commit messages to the log, which is bug 1188351.
The solution I proposed there is pretty simple, albeit has been waiting 4 months for the thumbs up by catlee.

Perhaps you could give him a poke? :-)

Comment 2

[Ed Morley [:emorley]]

(There's no easy way of doing this in Treeherder, it has no concept of where an error line occurred in the log)