1224345 - Validation errors on view_feature become ISEs

Status: RESOLVED WONTFIX

(developer.mozilla.org Graveyard :: BrowserCompat, defect)

Description

[John Whitlock [:jwhitlock]]

What did you do?
================
1. POSTed to /api/v1/view_feature from importer

What happened?
==============
A 500 error.

What should have happened?
==========================
A 400 error describing the validation error

Is there anything else we should know?
======================================
Traceback:

Internal Server Error: /api/v1/view_features/655
Traceback (most recent call last):
  File "/app/.heroku/python/lib/python2.7/site-packages/django/core/handlers/base.py", line 164, in get_response
    response = response.render()
  File "/app/.heroku/python/lib/python2.7/site-packages/django/template/response.py", line 158, in render
    self.content = self.rendered_content
  File "/app/.heroku/python/lib/python2.7/site-packages/rest_framework/response.py", line 71, in rendered_content
    ret = renderer.render(self.data, media_type, context)
  File "/app/.heroku/python/lib/python2.7/site-packages/rest_framework_json_api/renderers.py", line 56, in render
    wrapper = wrapper_method(data, renderer_context)
  File "/app/webplatformcompat/renderers.py", line 146, in wrap_view_extra_error
    name = 'linked.%s.%d.%s' % (rname, seq, fieldname)
TypeError: %d format: a number is required, not NoneType

seq=None indicates that it is the subject feature 655, and shouldn't appear under linked.X

Comment 1

[MDN Team (:mdn-dev)]

Commit pushed to master at https://github.com/mdn/browsercompat

https://github.com/mdn/browsercompat/commit/af03bf02a73987dd35e0ebd6a9f08d612ff2a21d
bug 1224345 - Format subject feature errors

On PUT to view_feature, the subject feature could have a validation
error that isn't detected until the second validation phase, with the
linked resources. In this case, the resource sequence is None, and the
renderer needs to expect this.

This doesn't fix the second-phase validation issue, but it will allow
better debugging when it does occur again.

Comment 2

[Renoir Boulanger [:renoirb]]

Is this fixed? http://bit.ly/mdn-browsercompat-backlog at #55 is done. It links to this issue, and this issue says it's new. What's the status?

Comment 3

[John Whitlock [:jwhitlock]]

It shouldn't be marked as done. I changed to 'current' on the backlog spreadsheet.

Comment 4

[John Whitlock [:jwhitlock]]

This bug appeared when committing data from the importer to the API, which is on hold until at least bug 1230306 (convert to UUIDs).

Comment 5

[John Whitlock [:jwhitlock]]

BrowserCompat project is canceled.