Status

defect
RESOLVED FIXED
4 years ago
2 years ago

People

(Reporter: jya, Unassigned)

Tracking

unspecified
Dependency tree / graph

Firefox Tracking Flags

(firefox45 affected)

Details

Bug 791513 updated yasm to 1.2 back in 2012.

mozilla-build was updated to yasm 1.3 in bug 1113450.

However, the build boxes still use yasm 1.1

As part of bug 1214462, we are integrating some parts of FFmpeg which requires yasm >= 1.2

Yasm 1.1 can't do AVX2 which is used by the VP9 decoder.
Chris - who can fix this issue?
Flags: needinfo?(catlee)
On Windows, Mark can let you know what's involved.
Flags: needinfo?(catlee) → needinfo?(mcornmesser)
Currently it would involve an adjustment to the base image for the try builders, and a GPO to catch the non-try builders. As well as include into my non-try builders testing. 


Ultimately it will should be rolled into Puppet once we get to automating the build AMI creation.
Flags: needinfo?(mcornmesser)
(In reply to Mark Cornmesser [:markco] from comment #3)
> Ultimately it will should be rolled into Puppet once we get to automating
> the build AMI creation.

What is the ETA for that?
mozilla-central has yasm code in libvpx, spidermonkey, skia, cairo, nss, libjpeg, and webrtc. We need to give those teams a heads-up when we update yasm.
Summary: Bump yasm to 1.2 → Bump yasm to 1.2 or later
(In reply to Chris Peterson [:cpeterson] from comment #5)
> mozilla-central has yasm code in libvpx, spidermonkey, skia, cairo, nss,
> libjpeg, and webrtc. We need to give those teams a heads-up when we update
> yasm.

The current mozilla-build already has 1.3 ; so anyone building locally would be using 1.3 already.
It's also the default on mac or any > 4 years old linux distribution.
(In reply to Anthony Jones (:kentuckyfriedtakahe, :k17e) from comment #4)
> (In reply to Mark Cornmesser [:markco] from comment #3)
> > Ultimately it will should be rolled into Puppet once we get to automating
> > the build AMI creation.
> 
> What is the ETA for that?

Puppet specifically will need to be after we have 2008 non-try builds working in AWS. However, without Puppet I can get it deployed this week.
I am rolling this into the AWS non-try build image today. This only a handful of instances, but hopefully we will be crossing over to AWS fully within the week. 

Grenade is going to handle updating the try AMI.
yasm in ec2/spot try was already at 1.2
I have bumped it to 1.3 (https://github.com/mozilla/build-cloud-tools/pull/141)
Thanks updating yasm, Rob! Resolving fixed as per comment 9.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
It may have been 1.2 on some machines, but certainly not all of them as enabling features requiring yasm 1.2 cause build failures
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Does that mean we can now use AVX2 on windows and others?is yasm >= 1.2 now available on some platforms?
which ones?
Flags: needinfo?(ajones)
Blocks: 1237907
So for Windows that works great now, and I've enabled AVX2 optimisation for the media decode.

What about the other platforms?
in particular mac.

Linux doesn't really matter as that particular code won't be used by 97% of linux users.
Ralph - do you know enough about Mac OSX tooling to help here?
Flags: needinfo?(giles)
Taskcluster mac builds have 1.2, per https://treeherder.mozilla.org/#/jobs?repo=try&revision=b41cef917d63&selectedJob=15298729. Waiting for confirmation on the native mac builds from the same try run.
Native builds say yasm version... 1.1.0.2352 (v1.1.0) so the images need updating. I don't know where that lives, but will ask.
The excellent jlund points me at https://hg.mozilla.org/build/puppet/log/tip/modules/packages/manifests/yasm-dmg.sh last touched by...dustin. Can you help us out with the bump?
Flags: needinfo?(dustin)
Sure, that's the script to build the new DMG.  How can I help?
Flags: needinfo?(dustin)
I've updated the script to build yasm 1.3.0 in bug 1238798. Can you take care of review and getting that deployed?
Jean-Yves, can we close this now?
Flags: needinfo?(giles) → needinfo?(jyavenard)
Blocks: 1240627
taking this into 1240627 for mac.

We still have Linux to take care off. It's currently yasm 1.1
Flags: needinfo?(jyavenard)
I'm going to un-ni myself because we're sorted for Windows at least.
Flags: needinfo?(ajones)
I'm going to close this. Linux beta builds use yasm 1.2.0.
Status: REOPENED → RESOLVED
Closed: 4 years ago2 years ago
Resolution: --- → FIXED
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.