1224460 - Many compilation-related variables contain make variables that are unsuitable in moz.build land

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

There are many of those, but for this bug, I'm mainly interested in those that affect compilation-related variables like CFLAGS, LDFLAGS, etc.

For instance, on Linux, TK_CFLAGS is literally '$(MOZ_GTK3_CFLAGS)', and is added to CXXFLAGS in many moz.build files.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Crude patch to print out the possibly problematic assignments and values

On an opt Linux build, this gives me the following problematic variables:
- TK_FLAGS ("$(MOZ_GTK3_CFLAGS)")
- MOZ_CAIRO_CFLAGS ("-I$(LIBXUL_DIST)/include/cairo")
- MOZ_ICU_CFLAGS ("-I$(topsrcdir)/intl/icu/source/i18n")
- things coming out of gyp.

The latter is a different story, it might need its own separate bug.

Comment 2

[Mike Hommey [:glandium]]

Other variables as taken across all platforms:
- TK_LIBS
- CAIRO_FT_CFLAGS

And it looks like it would be all.

Comment 3

[(not currently active) Ted Mielczarek]

If we're setting these in configure then it seems like we could let them be interpolated there. Presumably we're just explicitly quoting them so they persist to autoconf.mk?

Comment 4

[Mike Hommey [:glandium]]

Attachment: Use pwd -W to fill _topsrcdir in configure

We're going to be using -I$_topsrcdir in some CFLAGS variables, and for that
we need windows-y paths, not msys paths. All things currently using
$_topsrcdir should cope with this just fine.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Avoid make variable references in TK_CFLAGS, TK_LIBS, MOZ_CAIRO_CFLAGS, MOZ_ICU_CFLAGS and CAIRO_FT_CFLAGS

Comment 6

[Mike Hommey [:glandium]]

Attachment: Expand make variable references we get out of gyp

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/aeebc4c5fba7
https://hg.mozilla.org/integration/mozilla-inbound/rev/53e32f626afc
https://hg.mozilla.org/integration/mozilla-inbound/rev/7b54175c1241

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/aeebc4c5fba7
https://hg.mozilla.org/mozilla-central/rev/53e32f626afc
https://hg.mozilla.org/mozilla-central/rev/7b54175c1241

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7cff73db3cb2

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7cff73db3cb2