Closed Bug 1224460 Opened 4 years ago Closed 4 years ago

Many compilation-related variables contain make variables that are unsuitable in moz.build land

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox45 fixed)

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(4 files)

There are many of those, but for this bug, I'm mainly interested in those that affect compilation-related variables like CFLAGS, LDFLAGS, etc.

For instance, on Linux, TK_CFLAGS is literally '$(MOZ_GTK3_CFLAGS)', and is added to CXXFLAGS in many moz.build files.
On an opt Linux build, this gives me the following problematic variables:
- TK_FLAGS ("$(MOZ_GTK3_CFLAGS)")
- MOZ_CAIRO_CFLAGS ("-I$(LIBXUL_DIST)/include/cairo")
- MOZ_ICU_CFLAGS ("-I$(topsrcdir)/intl/icu/source/i18n")
- things coming out of gyp.

The latter is a different story, it might need its own separate bug.
Other variables as taken across all platforms:
- TK_LIBS
- CAIRO_FT_CFLAGS

And it looks like it would be all.
Depends on: 1224490
If we're setting these in configure then it seems like we could let them be interpolated there. Presumably we're just explicitly quoting them so they persist to autoconf.mk?
Assignee: nobody → mh+mozilla
We're going to be using -I$_topsrcdir in some CFLAGS variables, and for that
we need windows-y paths, not msys paths. All things currently using
$_topsrcdir should cope with this just fine.
Attachment #8688392 - Flags: review?(gps)
Attachment #8688392 - Flags: review?(gps) → review+
Attachment #8688395 - Flags: review?(gps) → review+
Attachment #8688397 - Flags: review?(gps) → review+
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.