1224510 - [Settings]The "Cancel" button on the action menu does not appear as an oval button.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Queena.Wen(Leave from Mozilla)]

Attachment: logcat_1756.txt

[1.Description]:
[Aries KK v2.5&2.6][Flame KK v2.5&2.6][Settings]The Cancel button will appear as a rectangular button similar to other options in the menu, with its text left-aligned and there is a blank space below it at the bottom of the screen.
See attachments: Aries_KK_v2.5.png&logcat_1756.txt
Found Time: 17:56

[2.Testing Steps]: 
The precondition: There is a paired bluetooth headphone/speaker
1. Launch the Setting---->Bluetooth
2. Tap the paired bluetooth headphone/speaker


[3.Expected Result]: 
2. The "Cancel" button should appear as an oval button.

[4.Actual Result]: 
2. The Cancel button will appear as a rectangular button similar to other options in the menu, with its text left-aligned and there is a blank space below it at the bottom of the screen.

[5.Reproduction build]: 
Device: Aries KK v2.5(Affected)
Build ID               20151112123156
Gaia Revision          240088d7a70dae41215ef61dd3fe3487709a4b65
Gaia Date              2015-11-12 10:13:01
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/e1f0fe73bc84ad2103a5c661bdd15c16a47d4af5
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151112.113956
Firmware Date          Thu Nov 12 11:40:03 UTC 2015
Bootloader             s1

Device: Flame KK v2.5 512mb(Affected)
Build ID               20151112122327
Gaia Revision          240088d7a70dae41215ef61dd3fe3487709a4b65
Gaia Date              2015-11-12 10:13:01
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/e1f0fe73bc84ad2103a5c661bdd15c16a47d4af5
Gecko Version          44.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151112.113741
Firmware Date          Thu Nov 12 11:37:51 UTC 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK v2.6 master(Affected)
Build ID               20151112120735
Gaia Revision          27bc9412ca607648bc398b25bb1ae25653b2b278
Gaia Date              2015-11-12 02:27:47
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/3cc3b1968524248450c465c4ea2ee5596ffa65f2
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151112.112635
Firmware Date          Thu Nov 12 11:26:43 UTC 2015
Bootloader             s1

Device: Flame KK v2.6 master 512mb(Affected)
Build ID               20151112150206
Gaia Revision          27bc9412ca607648bc398b25bb1ae25653b2b278
Gaia Date              2015-11-12 02:27:47
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/3cc3b1968524248450c465c4ea2ee5596ffa65f2
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151112.183236
Firmware Date          Thu Nov 12 18:32:49 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,10/10

[7.TCID]: 
Free Test

Comment 1

[Queena.Wen(Leave from Mozilla)]

Attachment: Flame KK v2.5.png

Comment 2

[Kevin Grandon :kgrandon]

I'll take and port to gaia-menu to fix this.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1224510_bluetooth_gaia_menu_fix > mozilla-b2g:master

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8687493 [details] [review]
[gaia] KevinGrandon:bug_1224510_bluetooth_gaia_menu_fix > mozilla-b2g:master

Hi Fred - could you review this when you have a chance? We need to port the menu to use gaia-menu which has a fix for the platform change.

I don't have a bluetooth speaker unfortunately, but I was able to test this path by hacking the code to show the menu. Thanks!

Comment 5

[Kevin Grandon :kgrandon]

[Blocking Requested - why for this release]: Visual regression, parent bugs is blocking so this should be also.

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8687493 [details] [review]
[gaia] KevinGrandon:bug_1224510_bluetooth_gaia_menu_fix > mozilla-b2g:master

Alternatively, Yura - maybe you have some cycles to review as a settings module peer? Thanks!

Comment 7

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8687493 [details] [review]
[gaia] KevinGrandon:bug_1224510_bluetooth_gaia_menu_fix > mozilla-b2g:master

Yep looks good, thanks Kevin!

Comment 8

[[e-mail]]

Comment on attachment 8687493 [details] [review]
[gaia] KevinGrandon:bug_1224510_bluetooth_gaia_menu_fix > mozilla-b2g:master

works fine, thanks!

Comment 9

[Kevin Grandon :kgrandon]

Thanks for the reviews.

In master: https://github.com/mozilla-b2g/gaia/commit/fbedbd59aef863664a1ac17643619a8e2b0ef5ff

Comment 10

[Shally Li（leave from Mozilla）]

Hi Queena,

    Could you please help verify this bug on master?

Thank you very much.

Comment 11

[Queena.Wen(Leave from Mozilla)]

Attachment: verified_Aries KK_v2.6.png

This bug has been verified as "pass" on the latest build of Aries KK master&Flame KK master 512mb by the STR in comment 0 .

Actual result: The "Cancel" button shows as an oval button. 
See attachment: verified_Aries KK_v2.6.png.
Reproduce rate: 0/10.

Device: Aries KK master(Pass)
Build ID               20151126174036
Gaia Revision          86959c405348d27ba5686956ae3a8ffc274d3db8
Gaia Date              2015-11-26 06:53:43
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/74c7941a9e22d50057800771ebae07f69deecc9f
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151126.165825
Firmware Date          Thu Nov 26 16:58:33 UTC 2015
Bootloader             s1

Device: Flame KK master 512mb(Pass)
Build ID               20151126172432
Gaia Revision          86959c405348d27ba5686956ae3a8ffc274d3db8
Gaia Date              2015-11-26 06:53:43
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/74c7941a9e22d50057800771ebae07f69deecc9f
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151126.164303
Firmware Date          Thu Nov 26 16:43:13 UTC 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0