1224547 - [Aries] test_gallery_view.py fails: AssertionError: 640 != 590

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Johan Lorenzo [:jlorenzo]]

> Traceback (most recent call last):
> File "/var/jenkins/1/workspace/aries.mozilla-central.nightly.ui.functional.smoke/.env/local/lib/python2.7/site-packages/marionette_client-1.0.0-py2.7.egg/marionette/marionette_test.py", line 296, in run
> testMethod()
> File "/var/jenkins/1/workspace/aries.mozilla-central.nightly.ui.functional.smoke/tests/python/gaia-ui-tests/gaiatest/tests/functional/gallery/test_gallery_view.py", line 46, in test_gallery_view
> self.assertEqual(self.device.screen_width, image.photo_toolbar_width)
> AssertionError: 640 != 590

Comment 1

[Johan Lorenzo [:jlorenzo]]

Found out the issue: the software home button is cropping a part of the screen which makes the value down to 590.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] JohanLorenzo:bug-1224547 > mozilla-b2g:master

Comment 3

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8687200 [details] [review]
[gaia] JohanLorenzo:bug-1224547 > mozilla-b2g:master

Tell me what you guys think.

Comment 4

[No-Jun Park [:njpark]]

Comment on attachment 8687200 [details] [review]
[gaia] JohanLorenzo:bug-1224547 > mozilla-b2g:master

Looks good other than the frame returning issue.

Comment 5

[Johan Lorenzo [:jlorenzo]]

(In reply to No-Jun Park [:njpark] from comment #4)
> Looks good other than the frame returning issue.
Discussed in the PR, we don't change that, for consistency for the other methods of the class.

Landed in master at: https://github.com/mozilla-b2g/gaia/commit/4562b5600b3344b4c72564c0dc139a05ce45f740