Closed Bug 1224580 Opened 9 years ago Closed 9 years ago

"Assertion failure: mSearchParams == aSearchParams" with non-ASCII in URLSearchParams

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla45
Tracking Flags:
Tracking Status
firefox45 --- fixed

People

(Reporter: jruderman, Assigned: bzbarsky)

References

Details

(Keywords: assertion, testcase)

Attachments

(3 files)

testcase
265 bytes, text/html
Details
stack
10.82 KB, text/plain
Details
Copy of URLSearchParams should not copy its observer pointer
2.20 KB, patch
baku
: review+
Details | Diff | Splinter Review
Attached file testcase — 
Assertion failure: mSearchParams == aSearchParams, at dom/base/URL.cpp:346
Attached file stack — 

    
    

    
  
Awesome.  This is fallout from http://hg.mozilla.org/mozilla-central/rev/a5cd9f18f1b6 as far as I can tell, which landed as a bustage fix with no review.  Again, as far as I can tell.

Yay lack of test coverage.
Blocks: 1169044

    
    

    
  
Luckily in opt builds the behavior is correct.

    
  
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED

        Attachment #8687505 -
        Flags: review?(amarchesini) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/91cfb76c82cd
Status: ASSIGNED → RESOLVED
Closed: 9 years ago

          status-firefox45:
          affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Component: DOM → DOM: Core & HTML

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: