1224600 - utf-8 + comma in To line breaks File | Send Unsent Messages

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Jonathan Kamens]

1. Create an address book entry with a display name in the form "Lastname, Firstname" where "Lastname" has a utf-8 character in it, e.g., "Fréédle, Froodle".

2. Compose a message to that recipient using address auto-completion.

3. File | Send Later.

4. In main window, File | Send Unsent Messages.

You will see: "There are non-ASCII characters in the local part of the recipient address . This is not yet supported. Please change this address and try again."

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: bug1224600_utf8_comma_unsent.patch

Shouldn't mime-decode when setting the compose fields. If we do then for comma-display-names we get something decoded that doesn't have quoted display name -> gets taken as two mailboxes later on -> one of the "two mailboxes" don't have an address -> you get the error message.

(The error message is misleading of course, I'll see to that in another bug.)

The display names aren't actually used for anything after this as only the addresses are used on the protocol level.

Comment 2

[Kent James (:rkent)]

Comment on attachment 8706035 [details] [diff] [review]
bug1224600_utf8_comma_unsent.patch

Review of attachment 8706035 [details] [diff] [review]:
-----------------------------------------------------------------

See bug 152690 for the original code that inserted this. I could not reproduce the issue in that bug after the current patch is implemented, so something must have changed. So let's try this.

Comment 3

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/rev/695cfc9ef250 -> FIXED

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 8706035 [details] [diff] [review]
bug1224600_utf8_comma_unsent.patch

Review of attachment 8706035 [details] [diff] [review]:
-----------------------------------------------------------------

Should land on auroara45 after trunk baking.

Comment 5

[Jonathan Kamens]

Does this need to be ported to SeaMonkey or does SeaMonkey get mailnews/compose fixes automatically?

Comment 6

[Magnus Melin [:mkmelin]]

mailnews/ is shared code so it's automatic

Comment 7

[Jorg K (CEST = GMT+2)]

Aurora:
https://hg.mozilla.org/releases/comm-aurora/rev/ddc209117ac2

Comment 8

[Rainer Bielefeld]

SM affected due to <http://blog.kamens.us/send-later/comment-page-3/#comment-1550987>