1224737 - Add pk11_gtest to all.sh run

Status: RESOLVED FIXED

(NSS :: Test, defect)

Description

[Martin Thomson [:mt:]]

Bug 1215295 added some tests, but they aren't getting run by the CI system.

Comment 1

[Martin Thomson [:mt:]]

Attachment: bug1224737.patch

I'm still running the tests, but I think that this is right.

Comment 2

[Martin Thomson [:mt:]]

Attachment: bug1224737-w.patch

This is the same as attachment 8687439 [details] [diff] [review], but with diff -w instead.  I realize that the other patch might have a little too much noise as a result of whitespace changes.

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8687439 [details] [diff] [review]
bug1224737.patch

Review of attachment 8687439 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM with the few nits fixed.

::: tests/pk11_gtests/pk11_gtests.sh
@@ +18,5 @@
> +#   NOTE .... unexpected behavior
> +#
> +########################################################################
> +
> +############################## ssl_gtest_init ##########################

pk11_gtest_init

@@ +38,5 @@
> +  html_head PKCS\#11 Gtests
> +
> +  if [ ! -d "${PK11GTESTDIR}" ]; then
> +    pk11_gtest_certs
> +  fi

This should be removed.

@@ +60,5 @@
> +  unset NSS_STRICT_SHUTDOWN
> +  SSLGTESTREPORT="${PK11GTESTDIR}/report.xml"
> +  ${BINDIR}/pk11_gtest -d "${PK11GTESTDIR}" --gtest_output=xml:"${PK11GTESTREPORT}"
> +  html_msg $? 0 "pk11_gtest run successfully"
> +  sed -f ${QADIR}/ssl_gtests/parsereport.sed "${PK11GTESTREPORT}" | \

/pk11_gtests/

Comment 4

[Martin Thomson [:mt:]]

Attachment: bug1224737v2.patch

https://hg.mozilla.org/projects/nss/rev/eff8e4bc3a7e

Made a few other small corrections to s/ssl_/pk11_/ as a result of running the tests.