1224848 - Intermittent e10s browser_pdfjs_zoom.js | Test timed out

Status: RESOLVED FIXED

(Firefox :: PDF Viewer, defect, P3)

Description

[Phil Ringnalda (:philor)]

https://treeherder.mozilla.org/logviewer.html#?job_id=17287991&repo=mozilla-inbound

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information

Comment 2

[Intermittent Failures Robot]

1 failures in 1862 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-central: 1

Platform breakdown:
* windows10-64-ccov: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1224848&startday=2018-12-03&endday=2018-12-09&tree=all

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The new failures are a regression from bug 786674. Snufflepagus, can you take a look?

Comment 4

[Intermittent Failures Robot]

16 failures in 792 pushes (0.02 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 10
• mozilla-central: 4
• mozilla-inbound: 2

Platform breakdown:

• macosx1014-64-shippable: 3
• linux64-shippable: 1
• windows10-64-shippable: 9
• windows7-32-shippable: 2
• windows10-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1224848&startday=2019-07-15&endday=2019-07-15&tree=all

Comment 5

[Jonas Jenwald [:Snuffleupagus]]

Attachment: zoom-cleanup.diff

(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #3)

The new failures are a regression from bug 786674. Snufflepagus, can you take a look?

Well, I cannot reproduce any failures locally on Windows so I'm not really sure what to do here.
The only idea I have is that we're not waiting for the viewer to close before ending the new zoom test, which maybe affects timings!?

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The log at https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=256690287&repo=mozilla-central&lineNumber=6430 shows that the new test executes until https://hg.mozilla.org/mozilla-central/file/64af83fa5586ed42ff59d8c645edaec9b28e3c88/browser/extensions/pdfjs/test/browser_pdfjs_zoom.js#l241 whose document content has viewer UI message at https://hg.mozilla.org/mozilla-central/file/64af83fa5586ed42ff59d8c645edaec9b28e3c88/browser/extensions/pdfjs/test/browser_pdfjs_zoom.js#l214 still gets printed. The await waitForRender after never resolves: https://hg.mozilla.org/mozilla-central/file/64af83fa5586ed42ff59d8c645edaec9b28e3c88/browser/extensions/pdfjs/test/browser_pdfjs_zoom.js#l217 - has the pagerendered event already been processed?

Comment 7

[Jonas Jenwald [:Snuffleupagus]]

Attachment: zoom-event-order.diff

(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #6)

The log at https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=256690287&repo=mozilla-central&lineNumber=6430 shows that the new test executes until https://hg.mozilla.org/mozilla-central/file/64af83fa5586ed42ff59d8c645edaec9b28e3c88/browser/extensions/pdfjs/test/browser_pdfjs_zoom.js#l241 whose document content has viewer UI message at https://hg.mozilla.org/mozilla-central/file/64af83fa5586ed42ff59d8c645edaec9b28e3c88/browser/extensions/pdfjs/test/browser_pdfjs_zoom.js#l214 still gets printed. The await waitForRender after never resolves: https://hg.mozilla.org/mozilla-central/file/64af83fa5586ed42ff59d8c645edaec9b28e3c88/browser/extensions/pdfjs/test/browser_pdfjs_zoom.js#l217 - has the pagerendered event already been processed?

As you've probably guessed I'm not very experienced with Firefox tests, so thank you for helping out with deciphering the test logs.
The only idea that jumped at me was to re-order the waitForRenderAndGetWidth calls and the FullZoom.{enlarge, reset, reduce} calls such that it (hopefully) should be impossible to miss an event.

:aryx, since I don't have try access: If you have time, could I maybe trouble you to help me push this patch to try to see if it helps at all?

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=71acdd9a89cdcf8f75f38e2c55b078f913524834

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

0/41 runs failed in Try run: https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=256754460&revision=71acdd9a89cdcf8f75f38e2c55b078f913524834

Comment 10

[Jonas Jenwald [:Snuffleupagus]]

Attachment: Bug 1224848 - Attempt to reduce intermittent test failures in the newly added PDF.js `FullZoom` tests by re-ordering the event registrations and zoom calls. r=bdahl

Comment 11

[Jonas Jenwald [:Snuffleupagus]]

(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #9)

0/41 runs failed in Try run: https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=256754460&revision=71acdd9a89cdcf8f75f38e2c55b078f913524834

:aryx, thanks a lot for helping out here!

These results certainly look promising enough so I've submitted an actual patch for review, fingers crossed it's enough to fix the new intermittent.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/606676e2dd21
Attempt to reduce intermittent test failures in the newly added PDF.js FullZoom tests by re-ordering the event registrations and zoom calls. r=bdahl

Comment 13

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/606676e2dd21

Comment 15

[Intermittent Failures Robot]

42 failures in 4298 pushes (0.01 failures/push) were associated with this bug in the last 7 days.

This is the #39 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 25
• mozilla-central: 6
• mozilla-inbound: 5
• try: 6

Platform breakdown:

• macosx1014-64-shippable: 3
• linux64-shippable: 2
• windows10-64-shippable: 25
• windows7-32-shippable: 2
• windows10-64: 4
• windows10-64-qr: 1
• macosx1010-64-devedition: 1
• windows10-64-devedition: 1
• macosx1010-64-shippable: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1224848&startday=2019-07-15&endday=2019-07-21&tree=all