1224990 - Intermittent test_smsc_address.js | got false, expected true - got , expected [phone]

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/logviewer.html#?job_id=13666247&repo=try

01:50:39     INFO -  TEST-START | test_smsc_address.js
01:50:43    ERROR -  TEST-UNEXPECTED-FAIL | test_smsc_address.js | got false, expected true - got , expected [phone]
01:50:43    ERROR -  TEST-UNEXPECTED-FAIL | test_smsc_address.js | got false, expected true - got unknown, expected international
01:50:45    ERROR -  TEST-UNEXPECTED-FAIL | test_smsc_address.js | AssertionError: 2 tests failed
01:50:45     INFO -  Traceback (most recent call last):
01:50:45     INFO -    File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/marionette/marionette_test.py", line 344, in run
01:50:45     INFO -      testMethod()
01:50:45     INFO -    File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/marionette/marionette_test.py", line 801, in runTest
01:50:45     INFO -      self.run_js_test(self.jsFile)
01:50:45     INFO -    File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/marionette/marionette_test.py", line 666, in run_js_test
01:50:45     INFO -      '%d tests failed' % len(results['failures']))
01:50:45     INFO -  TEST-INFO took 5705ms

Comment 1

[Intermittent Failures Robot]

16 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 11
* mozilla-central: 3
* fx-team: 2

Platform breakdown:
* b2g-emu-ics: 15
* windows8-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1224990&startday=2016-01-11&endday=2016-01-17&tree=all

Comment 2

[Bevis Tseng[:bevis][:btseng](Exited)]

Take this bug to follow-up:
1. There is potential flow in this test case:
   We didn't ensure that the ICC is ready before fetching the smsc adress.
2. test_smsc_address.js is redundant to test_set_smsc_address.js.
   I'll merge them together into single test case.

Comment 3

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: MozReview Request: Bug 1224990 - Untify SMSC Test Cases. r=edgar

Review commit: https://reviewboard.mozilla.org/r/31183/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31183/

Comment 4

[Bevis Tseng[:bevis][:btseng](Exited)]

https://reviewboard.mozilla.org/r/31183/#review27987

Comment 5

[Bevis Tseng[:bevis][:btseng](Exited)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c9695a60dc53

Comment 6

[Bevis Tseng[:bevis][:btseng](Exited)]

Comment on attachment 8708916 [details]
MozReview Request: Bug 1224990 - Untify SMSC Test Cases. r=edgar

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31183/diff/1-2/

Comment 7

[Edgar Chen [:edgar]]

Comment on attachment 8708916 [details]
MozReview Request: Bug 1224990 - Untify SMSC Test Cases. r=edgar

https://reviewboard.mozilla.org/r/31183/#review28101

Comment 8

[Bevis Tseng[:bevis][:btseng](Exited)]

treeherder result looks good in comment 5 after 30 trials.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/8ac887a51ee5

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8ac887a51ee5