Closed Bug 1224990 Opened 10 years ago Closed 9 years ago

Intermittent test_smsc_address.js | got false, expected true - got , expected +123456789

Categories

(Firefox OS Graveyard :: RIL, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(firefox46 fixed)

RESOLVED FIXED
Tracking Status
firefox46 --- fixed

People

(Reporter: edgar, Assigned: bevis)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

https://treeherder.mozilla.org/logviewer.html#?job_id=13666247&repo=try 01:50:39 INFO - TEST-START | test_smsc_address.js 01:50:43 ERROR - TEST-UNEXPECTED-FAIL | test_smsc_address.js | got false, expected true - got , expected +123456789 01:50:43 ERROR - TEST-UNEXPECTED-FAIL | test_smsc_address.js | got false, expected true - got unknown, expected international 01:50:45 ERROR - TEST-UNEXPECTED-FAIL | test_smsc_address.js | AssertionError: 2 tests failed 01:50:45 INFO - Traceback (most recent call last): 01:50:45 INFO - File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/marionette/marionette_test.py", line 344, in run 01:50:45 INFO - testMethod() 01:50:45 INFO - File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/marionette/marionette_test.py", line 801, in runTest 01:50:45 INFO - self.run_js_test(self.jsFile) 01:50:45 INFO - File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/marionette/marionette_test.py", line 666, in run_js_test 01:50:45 INFO - '%d tests failed' % len(results['failures'])) 01:50:45 INFO - TEST-INFO took 5705ms
Take this bug to follow-up: 1. There is potential flow in this test case: We didn't ensure that the ICC is ready before fetching the smsc adress. 2. test_smsc_address.js is redundant to test_set_smsc_address.js. I'll merge them together into single test case.
Assignee: nobody → btseng
Attachment #8708916 - Attachment description: MozReview Request: Bug 1224990 - Untify SMSC Test Cases. r=echen → MozReview Request: Bug 1224990 - Untify SMSC Test Cases. r=edgar
Attachment #8708916 - Flags: review?(echen)
Comment on attachment 8708916 [details] MozReview Request: Bug 1224990 - Untify SMSC Test Cases. r=edgar Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31183/diff/1-2/
Attachment #8708916 - Flags: review?(echen) → review+
Comment on attachment 8708916 [details] MozReview Request: Bug 1224990 - Untify SMSC Test Cases. r=edgar https://reviewboard.mozilla.org/r/31183/#review28101
treeherder result looks good in comment 5 after 30 trials.
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: