1225023 - NPAPI sandbox is blocking flash from creating the "Flash Player" parent directories.

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect)

Description

[Bob Owen (:bobowen)]

We give r/w access to everything under %APPDATA%\Adobe\Flash Player\ and %APPDATA%\Macromedia\Flash Player\.

However if these don't exist for some reason, then the Flash Player gets blocked from creating them.

Comment 1

[Bob Owen (:bobowen)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8f687ca18e9e

Comment 2

[Bob Owen (:bobowen)]

Attachment: Allow Flash Player to create Adobe\Flash Player and Macromedia\Flash Player directories.

Comment 3

[Brian R. Bondy [:bbondy]]

Comment on attachment 8687858 [details] [diff] [review]
Allow Flash Player to create Adobe\Flash Player and Macromedia\Flash Player directories.

Review of attachment 8687858 [details] [diff] [review]:
-----------------------------------------------------------------

Does this apply for content processes and plugins? 
Just wondering if this makes a larger attack surface since if a junction exists in that directory it could be exploited by anything and not just flash?
Can it apply to only the flash instead?

Comment 4

[Bob Owen (:bobowen)]

(In reply to Brian R. Bondy [:bbondy] from comment #3)
> Comment on attachment 8687858 [details] [diff] [review]
> Allow Flash Player to create Adobe\Flash Player and Macromedia\Flash Player
> directories.
> 
> Review of attachment 8687858 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Does this apply for content processes and plugins? 
> Just wondering if this makes a larger attack surface since if a junction
> exists in that directory it could be exploited by anything and not just
> flash?
> Can it apply to only the flash instead?

This only applies to NPAPI processes and therefore just flash 64-bit, as it is the only one for which we have the sandbox turned on.

The content process (in Nightly) can only write to low integrity directories.

Comment 5

[Brian R. Bondy [:bbondy]]

Comment on attachment 8687858 [details] [diff] [review]
Allow Flash Player to create Adobe\Flash Player and Macromedia\Flash Player directories.

Review of attachment 8687858 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds good, thanks.

Comment 6

[Bob Owen (:bobowen)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fd53b630ea8b68248d8a2b74c10d4c507826364d
Bug 1225023: Allow Flash Player to create Adobe\Flash Player and Macromedia\Flash Player directories. r=bbondy

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fd53b630ea8b

Comment 8

[Bob Owen (:bobowen)]

Comment on attachment 8687858 [details] [diff] [review]
Allow Flash Player to create Adobe\Flash Player and Macromedia\Flash Player directories.

Approval Request Comment
[Feature/regressing bug #]:
Bug 1185532, which turned on the NPAPI sandbox for flash on 64-bit, caused this regression.

[User impact if declined]:
Users who delete their Flash Player or Adobe/Macromedia directories will lose certain Flash functionality that relies on these directories. This includes caching and licences for viewing video.

[Describe test coverage new/current, TreeHerder]:
Fix confirmed by original reporter at Adobe.

[Risks and why]:
Low - fairly small code change along the lines of existing code. New sandbox rules only give control over specific directories.

[String/UUID change made/needed]:
None

Comment 9

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8687858 [details] [diff] [review]
Allow Flash Player to create Adobe\Flash Player and Macromedia\Flash Player directories.

Fix for recent regression, preventing data loss sounds good.
Approved for uplift to aurora and beta.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f0282ad221a3

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f34e97d70cfe

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/f0282ad221a3