1225038 - Remove obsolete functions from NotificationCollection

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P2)

Description

[Mark Banner (:standard8)]

From investigation, the following functions in NotificationCollection are obsolete and can be removed:

warn,warnL10,error,errorL10,success,successL10n

Although this leaves very little functionality for NotificationCollection (its basically just a backbone collection), we'll be changing how it works in a follow-up bug.

Comment 1

[Mark Banner (:standard8)]

Note, I forgot to mention that the associated tests should also be removed.

Comment 2

[Mark Banner (:standard8)]

Note: Loop development is now in https://github.com/mozilla/loop there are readme and contributing documents in the repository.

Comment 3

[GitHub Autolander Bot]

Attachment: [loop] malayaleecoder:Bug1225038 > mozilla:master

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 8718046 [details] [review]
[loop] malayaleecoder:Bug1225038 > mozilla:master

Looks good, please squash the commits and add ", r=Standard8" onto the end of the commit message.

Thank you for the work on this.

Comment 5

[Vishnu (:malayaleecoder)]

Hello Mark,

I have squashed the commits into the PR. Please have a look.
Do suggest me more bugs for fix in Loop :)

Comment 6

[Mark Banner (:standard8)]

Ok, something didn't go quite right with that push. What you need to do to get out it, I think is:

git checkout master
git pull upstream master
git checkout Bug1225038
git rebase -i master

When you do the rebase command, it'll ask you which commits you want to keep. Remove all the lines apart from the good one - 603032a, I think, then save the file and exit. That should get you just the good commit on the branch.

You then need to:

git push -f origin Bug1225038

which will overwrite the branch on your remote, and hopefully get down to just one commit.

Comment 7

[Vishnu (:malayaleecoder)]

@Mark: Done, please check :)

Comment 8

[Mark Banner (:standard8)]

Much better

https://github.com/mozilla/loop/commit/7bb7eea0b2b2acd9760aa91033a5f01da25df607

Thank you for your work on this.

(In reply to malayaleecoder from comment #5)
> Do suggest me more bugs for fix in Loop :)

Bug 1225057 would be the next one in this series - I think its a bit more difficult, but if you do it split up into the patches suggested in the user story (they could be separate PRs or commits on the sam PR), I think it would be a good next step.

Comment 9

[Vishnu (:malayaleecoder)]

Anytime:) I already started doing Bug 1225057. See you there!