1225045 - GFX build error on flatfish

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Flatfish builds output the error shown above.

> The error occurred while processing the following file or one of the files it includes:
> 
>     /home/mozilla/Projects/mozilla/src/hg.mozilla.org/mozilla-central/gfx/layers/moz.build
> 
> The error occurred when validating the result of the execution. The reported error is:
> 
>     Path specified in LOCAL_INCLUDES does not exist: %/home/mozilla/Projects/mozilla/src/B2G-master-flatfish/frameworks/base/include/media/stagefright (resolved to /home/mozilla/Projects/mozilla/src/B2G-master-flatfish/frameworks/base/include/media/stagefright)

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 1225045: Fix stagefright include paths for ANDROID_VERSION >= 17

Flatfish uses ANDROID_VERSION == 17. This looks like fallout from bug 1221453.

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8687850 [details] [diff] [review]
[01] Bug 1225045: Fix stagefright include paths for ANDROID_VERSION >= 17

Review of attachment 8687850 [details] [diff] [review]:
-----------------------------------------------------------------

I don't understand where the off by 1 bug came from. But this seems innocuous enough. If you understand, please write a more detailed commit message next time to make this easier to review and investigate in the future.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/6ccd98a8727b

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=6ccd98a8727b

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6ccd98a8727b