GFX build error on flatfish

RESOLVED FIXED in Firefox 45

Status

Firefox OS
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: tzimmermann, Assigned: tzimmermann)

Tracking

unspecified
2.6 S1 - 11/20
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(firefox45 fixed)

Details

Attachments

(1 attachment)

Flatfish builds output the error shown above.

> The error occurred while processing the following file or one of the files it includes:
> 
>     /home/mozilla/Projects/mozilla/src/hg.mozilla.org/mozilla-central/gfx/layers/moz.build
> 
> The error occurred when validating the result of the execution. The reported error is:
> 
>     Path specified in LOCAL_INCLUDES does not exist: %/home/mozilla/Projects/mozilla/src/B2G-master-flatfish/frameworks/base/include/media/stagefright (resolved to /home/mozilla/Projects/mozilla/src/B2G-master-flatfish/frameworks/base/include/media/stagefright)
Created attachment 8687850 [details] [diff] [review]
[01] Bug 1225045: Fix stagefright include paths for ANDROID_VERSION >= 17

Flatfish uses ANDROID_VERSION == 17. This looks like fallout from bug 1221453.
Assignee: nobody → tzimmermann
Status: NEW → ASSIGNED
Attachment #8687850 - Flags: review?(gps)

Comment 2

2 years ago
Comment on attachment 8687850 [details] [diff] [review]
[01] Bug 1225045: Fix stagefright include paths for ANDROID_VERSION >= 17

Review of attachment 8687850 [details] [diff] [review]:
-----------------------------------------------------------------

I don't understand where the off by 1 bug came from. But this seems innocuous enough. If you understand, please write a more detailed commit message next time to make this easier to review and investigate in the future.
Attachment #8687850 - Flags: review?(gps) → review+

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6ccd98a8727b
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.6 S1 - 11/20
You need to log in before you can comment on or make changes to this bug.