Closed Bug 1225124 Opened 6 years ago Closed 6 years ago
Mozharness should not fatal exit if symbols URL cannot be found
MozReview Request: Bug 1225124 - Mozharness should not fatal exit if symbols URL cannot be found. r=ted
58 bytes, text/x-review-board-request
Mozharness still requires a symbols URL to be set. According to Ted this is no longer necessary given that mozcrash can automatically detect which symbols it has to download on demand. I don't know how many test suites are making use of the symbols URL right now and if we should completely remove its existence. Maybe lesser invasive would be to make this URL optional for now and log a deprecation warning? With this change it would also be possible to only specify an installer path and to save the download of the binary if already present locally. Ted, what do you think?
I think it should be made optional. That's what I did for firefox-media-tests.
It's still needed for testing non-nightly/release builds, since those symbols aren't on the symbol server.
That is correct, but as of now the mozharness script would fatal exit if no symbols can be determined. That happens if no installer-url has been specified but e.g. an installer-path or binary. The upcoming patch will exchange the FATAL exit with a warning.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Summary: Mozharness should no longer require symbols URL → Mozharness should not fatal exit if symbols URL cannot be found
Review commit: https://reviewboard.mozilla.org/r/38929/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/38929/
Attachment #8728384 - Flags: review?(ted)
Comment on attachment 8728384 [details] MozReview Request: Bug 1225124 - Mozharness should not fatal exit if symbols URL cannot be found. r=ted https://reviewboard.mozilla.org/r/38929/#review36209 After looking at the desktop_unittest script I feel OK that this won't accidentally break anything.
Attachment #8728384 - Flags: review?(ted) → review+
Yes, all tasks as triggered via buildbot or taskcluster will get this symbol URL. On the other side why should we stop the execution of a full test suite only because the symbols URL is not known.
(In reply to Henrik Skupin (:whimboo) from comment #6) > Yes, all tasks as triggered via buildbot or taskcluster will get this symbol > URL. On the other side why should we stop the execution of a full test suite > only because the symbols URL is not known. Because for most of our tests, running against non-nightly builds, not having a symbols URL means crashes and assertions will produce unactionable logs. It's better to just error ahead of time if the symbols URL isn't set in that case to avoid it being broken for a long time until someone notices because they can't debug a problem.
You need to log in before you can comment on or make changes to this bug.