1225174 - Limit the number of fetched bookmark batches on first sync

Status: NEW

(Firefox for iOS :: Sync, defect)

Description

[Richard Newman [:rnewman]]

Similar to Bug 1225164.

If you have a ton of bookmarks on the server, we'll keep downloading batches of 100 until we're done.

If you have 1725 bookmarks and folders (like me, a light user of bookmarks for several years), that means 18 batches.

We won't sync *any* history until we're done syncing your bookmarks.

(Similarly, we won't get to bookmarks until we're done grabbing your logins… that's another story.)


I suggest that we should provide a limited greenlight, if only for first syncs, so that we don't delay fetching some history and getting back to browsing.

A slightly more sophisticated version of this is to fetch the first batch of history early, then a few batches of bookmarks, then more history…

Here's the relevant code.

        private func mirrorBookmarksWithDelegate(delegate: SyncDelegate, prefs: Prefs, ready: Ready) -> SyncResult {
            log.debug("Mirroring server bookmarks to storage.")
            let bookmarksMirrorer = ready.synchronizer(MirroringBookmarksSynchronizer.self, delegate: delegate, prefs: prefs)
            return bookmarksMirrorer.mirrorBookmarksToStorage(self.profile.mirrorBookmarks, withServer: ready.client, info: ready.info, greenLight: self.greenLight())
        }