Closed Bug 1225194 Opened 6 years ago Closed 6 years ago

click on awesome bar item from another device doesn't open URL

Categories

(Firefox :: Sync, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 45
Tracking Status
firefox45 --- fixed

People

(Reporter: edwong, Assigned: markh)

References

Details

Attachments

(1 file)

1. on another device, open a tab with 'news' in the title
2. on desktop, type 'news' in awesome bar
3. select row from with the sub title 'Your tab from other device'

actual:
moz-action:remotetab,{"url":"https://www.google.com/search?q=izakayz roku&ie=utf-8&oe=utf-8","deviceName":"Fennec%20Aurora%20on%20Pad","originalUrl":"https://www.google.com/search?q=izakayz%20roku&ie=utf-8&oe=utf-8"}

expected: jumps to URL as expected
Assignee: nobody → markh
Blocks: 1210616
well, that's embarrassing :) It looks like the code to actually take the action got lost somewhere. This patch fixes that and also adds a test.
Attachment #8688195 - Flags: review?(mak77)
Comment on attachment 8688195 [details] [diff] [review]
0001-Bug-1225194-hook-up-remotetab-action-to-tabs-from-ot.patch

Review of attachment 8688195 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/test/general/browser_bug1225194-remotetab.js
@@ +11,5 @@
> +  EventUtils.synthesizeKey("VK_RETURN", {});
> +
> +  yield promiseTabLoaded;
> +
> +  Assert.equal(gBrowser.selectedTab.linkedBrowser.currentURI.spec, url, "correct URL loaded");

doesn't look like the test is cleaning up after itself for the next tests. It would probably be better to open a new tab, and close it when done (BrowserTestUtils.withNewTab could be handy)
Attachment #8688195 - Flags: review?(mak77) → review+
(In reply to Marco Bonardo [::mak] from comment #3)
> doesn't look like the test is cleaning up after itself for the next tests.
> It would probably be better to open a new tab, and close it when done
> (BrowserTestUtils.withNewTab could be handy)

It's actually OK because there's no new tab open - the current tab is replaced by the action. The test harness itself resets the 1 remaining tab to about:blank (although I guess I could do that too if you are bothered by that?)
I was just wondering that testing in a new tab is less likely to "break" future tests making assumptions on the pre existing tab (like session history or such). I don't recall if the harness replaces the first tab before each test.
it's not critical, just that I usually prefer to keep each test well separated.
OK, I've pushed this with the test creating a new tab, thanks.
https://hg.mozilla.org/mozilla-central/rev/13ccab8d10bb
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
You need to log in before you can comment on or make changes to this bug.